commit 49d1eeaab4085cd0284ee041f4775aaa982074c6
author Ed Tanous <edtanous@google.com> Fri Jan 07 09:39:33 2022 -0800
committer Ed Tanous <ed@tanous.net> Wed Jan 12 19:00:37 2022 +0000
tree 371a4a015aa5514068bd4b47bb6afe9ce01de0b5
parent 4bac4a89b2739caf9bb250327757c44dd5f35c16

enable cppcoreguidelines-pro-type-vararg checks

We only use varargs in some code we borrowed from nlohmann, so ignore
that, and enable the check.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iab1305784e7532e2ee10c617fb59b75aba142ce6

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 93db922..b708a70 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -210,6 +210,7 @@
 cppcoreguidelines-pro-type-cstyle-cast,
 cppcoreguidelines-pro-type-member-init,
 cppcoreguidelines-pro-type-reinterpret-cast,
+cppcoreguidelines-pro-type-vararg,
 cppcoreguidelines-special-member-functions,
 misc-misplaced-const,
 #misc-no-recursion,

include/json_html_serializer.hpp

diff --git a/include/json_html_serializer.hpp b/include/json_html_serializer.hpp
index 4969d27..8e3cce5 100644
--- a/include/json_html_serializer.hpp
+++ b/include/json_html_serializer.hpp
@@ -161,14 +161,16 @@
                         {
                             if (codePoint <= 0xFFFF)
                             {
-                                (std::snprintf)(
-                                    stringBuffer.data() + bytes, 7, "\\u%04x",
-                                    static_cast<uint16_t>(codePoint));
+                                // NOLINTNEXTLINE(cppcoreguidelines-pro-type-vararg)
+                                std::snprintf(stringBuffer.data() + bytes, 7,
+                                              "\\u%04x",
+                                              static_cast<uint16_t>(codePoint));
                                 bytes += 6;
                             }
                             else
                             {
-                                (std::snprintf)(
+                                // NOLINTNEXTLINE(cppcoreguidelines-pro-type-vararg)
+                                std::snprintf(
                                     stringBuffer.data() + bytes, 13,
                                     "\\u%04x\\u%04x",
                                     static_cast<uint16_t>(0xD7C0 +
@@ -400,6 +402,7 @@
     static constexpr auto d = std::numeric_limits<double>::max_digits10;
 
     // the actual conversion
+    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-vararg)
     std::ptrdiff_t len = std::snprintf(numberbuffer.data(), numberbuffer.size(),
                                        "%.*g", d, number);