Change the word TS to Time Stamp & add time unit
- The Message argument in the BIOSPOSTCode Message Entry
uses short form wording for TS (Time Stamp) & without any time unit.
- As the Message argument is directly displayed on OpenBMC GUI
as it is, word "TS" would create customer confusion due to it
not being a well known acronym. Also a field like this that
captures a physical quantity(time) should have units.
- Redfish clients should not be parsing the message argument, so
changing this wording should not break them.
- Also, this commit changes ":" to ";" in the Message argument to
makes things look consistent.
- As we changed the content of Message in the Message Entry, we had to
bump up the minor version of the Message registry.
Tested By:
1. Redfish Validator Passed.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I17924c2dfdcf34563f8f8cd325011e13cb70e476
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp
index fa4e41a..a1761bb 100644
--- a/redfish-core/include/event_service_manager.hpp
+++ b/redfish-core/include/event_service_manager.hpp
@@ -444,7 +444,7 @@
{"EventType", "Event"},
{"Severity", "OK"},
{"Message", "Generated test event"},
- {"MessageId", "OpenBMC.0.1.TestEventLog"},
+ {"MessageId", "OpenBMC.0.2.TestEventLog"},
{"MessageArgs", nlohmann::json::array()},
{"EventTimestamp", crow::utility::dateTimeNow()},
{"Context", customText}};
diff --git a/redfish-core/include/registries/openbmc_message_registry.hpp b/redfish-core/include/registries/openbmc_message_registry.hpp
index 5eb9380..ba32c11 100644
--- a/redfish-core/include/registries/openbmc_message_registry.hpp
+++ b/redfish-core/include/registries/openbmc_message_registry.hpp
@@ -21,12 +21,12 @@
const Header header = {
"Copyright 2018 OpenBMC. All rights reserved.",
"#MessageRegistry.v1_4_0.MessageRegistry",
- "OpenBMC.0.1.0",
+ "OpenBMC.0.2.0",
"OpenBMC Message Registry",
"en",
"This registry defines the base messages for OpenBMC.",
"OpenBMC",
- "0.1.0",
+ "0.2.0",
"OpenBMC",
};
constexpr std::array<MessageEntry, 187> registry = {
@@ -186,16 +186,17 @@
},
"None.",
}},
- MessageEntry{"BIOSPOSTCode",
- {
- "BIOS Power-On Self-Test Code received",
- "Boot Count: %1: TS Offset: %2; POST Code: %3",
- "OK",
- "OK",
- 3,
- {"number", "number", "number"},
- "None.",
- }},
+ MessageEntry{
+ "BIOSPOSTCode",
+ {
+ "BIOS Power-On Self-Test Code received",
+ "Boot Count: %1; Time Stamp Offset: %2 seconds; POST Code: %3",
+ "OK",
+ "OK",
+ 3,
+ {"number", "number", "number"},
+ "None.",
+ }},
MessageEntry{"BIOSPOSTError",
{
"Indicates BIOS POST has encountered an error.",
diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index d229c48..8464d06 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -3176,7 +3176,7 @@
{
// Get the Message from the MessageRegistry
const message_registries::Message* message =
- message_registries::getMessage("OpenBMC.0.1.BIOSPOSTCode");
+ message_registries::getMessage("OpenBMC.0.2.BIOSPOSTCode");
uint64_t currentCodeIndex = 0;
nlohmann::json& logEntryArray = aResp->res.jsonValue["Members"];
@@ -3278,7 +3278,7 @@
{"Name", "POST Code Log Entry"},
{"Id", postcodeEntryID},
{"Message", std::move(msg)},
- {"MessageId", "OpenBMC.0.1.BIOSPOSTCode"},
+ {"MessageId", "OpenBMC.0.2.BIOSPOSTCode"},
{"MessageArgs", std::move(messageArgs)},
{"EntryType", "Event"},
{"Severity", std::move(severity)},
diff --git a/redfish-core/src/error_messages.cpp b/redfish-core/src/error_messages.cpp
index 7059a38..ad5f819 100644
--- a/redfish-core/src/error_messages.cpp
+++ b/redfish-core/src/error_messages.cpp
@@ -2111,7 +2111,7 @@
{
return nlohmann::json{
{"@odata.type", "/redfish/v1/$metadata#Message.v1_1_1.Message"},
- {"MessageId", "OpenBMC.0.1.0.InvalidUpload"},
+ {"MessageId", "OpenBMC.0.2.InvalidUpload"},
{"Message", "Invalid file uploaded to " + arg1 + ": " + arg2 + "."},
{"MessageArgs", {arg1, arg2}},
{"MessageSeverity", "Warning"},