tree 2926de5b21d5da936405677689e06b3d1107246d
parent 3602e232fda4a6ddac4dcf6d3a024bd5ff6e7835
author Ed Tanous <ed.tanous@intel.com> 1556927997 -0700
committer Ed Tanous <ed.tanous@intel.com> 1558393149 +0000

Fix 404 handling in Redfish EthernetInterfaces

Previously, when a user requested a network interface that was
non-sensical, like:
/redfish/v1/Managers/bmc/EthernetInterfaces/foobar/VLANs
OR
/redfish/v1/Managers/bmc/EthernetInterfaces/foobar

They would be presented with a 200-OK, and a partially filled in object.
While this doesn't matter much for the casual redfish user, who uses the
collection to properly enumerate devices, this causes an issue with
security scanners, which think they've found some vulnerability when
they can throw whatever injection text they want to in the message, and
it shows up in the response.

This patchset corrects this, and causes the urls referenced above to
properly return 404, and the appropriate "ResourceNotFound" error
message.

Tested:
Attempted both URLs shown above.  Both return 404.

Ran redfish service validator, observed no errors related to
EthernetInterface, or sub nodes.  Attempted good URLs, and observed no
change to the payload.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: Idb2758858d4dbaf421c0cef28b1d5d02402e0ad8