commit 4da0490bc07a458ad3fc7d586c7eabf6053c572f
author Ed Tanous <ed@tanous.net> Tue Mar 19 11:32:44 2024 -0700
committer Ed Tanous <ed@tanous.net> Mon Apr 01 16:37:05 2024 +0000
tree e2a22f818710b05bd9d89bac8c65cdfba492fefb
parent 93cf0ac2c7921d3344fa112f667c47a838e3b7d6

Use no-switch-default on clang

clang-18 improves this check so that we can actually use it.  Enable it
and fix all violations.

Change-Id: Ibe4ce19c423d447a4cbe593d1abba948362426af
Signed-off-by: Ed Tanous <ed@tanous.net>

http/routing.hpp

diff --git a/http/routing.hpp b/http/routing.hpp
index 562abaf..921bfe8 100644
--- a/http/routing.hpp
+++ b/http/routing.hpp
@@ -319,7 +319,7 @@
                     case ParamType::PATH:
                         BMCWEB_LOG_DEBUG("<path>");
                         break;
-                    case ParamType::MAX:
+                    default:
                         BMCWEB_LOG_DEBUG("<ERROR>");
                         break;
                 }

http/verb.hpp

diff --git a/http/verb.hpp b/http/verb.hpp
index 5eacfbe..5859d10 100644
--- a/http/verb.hpp
+++ b/http/verb.hpp
@@ -67,7 +67,7 @@
             return "PUT";
         case HttpVerb::Options:
             return "OPTIONS";
-        case HttpVerb::Max:
+        default:
             return "";
     }
 

include/multipart_parser.hpp

diff --git a/include/multipart_parser.hpp b/include/multipart_parser.hpp
index 9adf564..924ee8d 100644
--- a/include/multipart_parser.hpp
+++ b/include/multipart_parser.hpp
@@ -209,6 +209,8 @@
                 }
                 case State::END:
                     break;
+                default:
+                    return ParserError::ERROR_UNEXPECTED_END_OF_INPUT;
             }
         }
 

meson.build

diff --git a/meson.build b/meson.build
index e9223dd..44ee65d 100644
--- a/meson.build
+++ b/meson.build
@@ -150,6 +150,7 @@
     '-Wno-weak-vtables',
     '-Wno-switch-enum',
     '-Wno-unused-macros',
+    '-Wno-covered-switch-default',
     language:'cpp')
 endif
 

redfish-core/include/utils/query_param.hpp

diff --git a/redfish-core/include/utils/query_param.hpp b/redfish-core/include/utils/query_param.hpp
index fa2b4da..c687444 100644
--- a/redfish-core/include/utils/query_param.hpp
+++ b/redfish-core/include/utils/query_param.hpp
@@ -717,6 +717,8 @@
             queryTypeExpected = true;
             str += '*';
             break;
+        default:
+            return std::nullopt;
     }
     if (!queryTypeExpected)
     {

redfish-core/lib/sensors.hpp

diff --git a/redfish-core/lib/sensors.hpp b/redfish-core/lib/sensors.hpp
index 002ee3f..8506185 100644
--- a/redfish-core/lib/sensors.hpp
+++ b/redfish-core/lib/sensors.hpp
@@ -712,7 +712,7 @@
             case LedState::BLINK:
                 sensorJson["IndicatorLED"] = "Blinking";
                 break;
-            case LedState::UNKNOWN:
+            default:
                 break;
         }
     }

src/json_html_serializer.cpp

diff --git a/src/json_html_serializer.cpp b/src/json_html_serializer.cpp
index 5473b1d..3e0e5f8 100644
--- a/src/json_html_serializer.cpp
+++ b/src/json_html_serializer.cpp
@@ -539,7 +539,7 @@
             out += "null";
             return;
         }
-        case nlohmann::json::value_t::binary:
+        default:
         {
             // Do nothing;  Should never happen.
             return;