Remove try-catch blocks on handleUpgrade
handleUpgrade is pretty simple, and has no methods that can throw. This
was there previously because of handling exceptions in handle() and was
copied to handleUpgrade(), even though it doesn't make a ton of sense to
do so, given the throw conditions don't really exist, and start()
doesn't call path handlers directly anymore.
Tested: Code compiles. Only affects error conditions.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iedd7e42b7e908282ab2c2d698e9f6c815b88e857
diff --git a/http/routing.hpp b/http/routing.hpp
index d35e4b4..40218fb 100644
--- a/http/routing.hpp
+++ b/http/routing.hpp
@@ -1388,28 +1388,8 @@
<< "' " << static_cast<uint32_t>(*verb) << " / "
<< rules[ruleIndex]->getMethods();
- // any uncaught exceptions become 500s
- try
- {
- rules[ruleIndex]->handleUpgrade(req, asyncResp,
- std::forward<Adaptor>(adaptor));
- }
- catch (const std::exception& e)
- {
- BMCWEB_LOG_ERROR << "An uncaught exception occurred: " << e.what();
- asyncResp->res.result(
- boost::beast::http::status::internal_server_error);
- return;
- }
- catch (...)
- {
- BMCWEB_LOG_ERROR
- << "An uncaught exception occurred. The type was unknown "
- "so no information was available.";
- asyncResp->res.result(
- boost::beast::http::status::internal_server_error);
- return;
- }
+ rules[ruleIndex]->handleUpgrade(req, asyncResp,
+ std::forward<Adaptor>(adaptor));
}
void handle(Request& req,