Make code compile with clang-13
Clang-13 rightfully warns that the hasWebuiRoute variable isn't declared
as static. This commit resolves that, and adds the static keyword so it
can be used in multiple compile units. It also adds the static keyword
to the privilege registry, and the inline keyword to many methods that
now need it.
clang-format is also updated to version 12 in parse_registies.py, as
that's what CI uses, and what most people have installed.
Tested:
Followed clang-tidy instructions in README.md
"bitbake bmcweb" step now succeeds.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id43b13606754cb37a404799fce155599ac3a3240
diff --git a/scripts/parse_registries.py b/scripts/parse_registries.py
index 5f2229c..3d66a03 100755
--- a/scripts/parse_registries.py
+++ b/scripts/parse_registries.py
@@ -50,7 +50,7 @@
def clang_format(filename):
- subprocess.check_call(["clang-format-11", "-i", filename])
+ subprocess.check_call(["clang-format-12", "-i", filename])
files = []
@@ -167,7 +167,7 @@
privilege_list)
operation = operation.lower()
- registry.write("const auto& {}{} = privilegeSet{};\n".format(
+ registry.write("const static auto& {}{} = privilegeSet{};\n".format(
operation, entity , privilege_dict[privilege_string][1]))
registry.write("\n")
registry.write("} // namespace redfish::privileges\n")