EventService: Enhance inotify event filename handling
In kernel inotify, the inotify_event.name is padded to a mutiple of
sizeof(inotify_event) with '\0' and len is the size of char[] name,
not the actual size of name. So constructing the name string with
std::string(name, len) constructs a string with all the '\0's, which
is not equal to the filename. This patch uses std::string(name) so
that the string does not contain these '\0's.
Tested:
Manually create/delete /var/log/redfish, confirmed handler is entered
by log.
Change-Id: Ibaa96dd5c47b0205541a6ee155daa593b2e2114d
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp
index 759c798..2c1ebfb 100644
--- a/redfish-core/include/event_service_manager.hpp
+++ b/redfish-core/include/event_service_manager.hpp
@@ -1206,9 +1206,8 @@
continue;
}
- std::string fileName(&readBuffer[index + iEventSize],
- event.len);
- if (std::strcmp(fileName.c_str(), "redfish") != 0)
+ std::string fileName(&readBuffer[index + iEventSize]);
+ if (fileName != "redfish")
{
index += (iEventSize + event.len);
continue;