commit 51dab2a7284b0f7adf2296e4165bdf8a63e73b7d
author Andrew Geissler <geissonator@yahoo.com> Tue May 30 15:07:46 2023 -0400
committer Andrew Geissler <geissonator@yahoo.com> Thu Jun 01 12:50:10 2023 -0400
tree 2038b0846509b4cb456b3fdf5754cd2187820c1c
parent 099793f4fd4754940b7dcada75c055c5d86449a0

chassis: consistently log error on internal fails

Debugging internalError responses from bmcweb has been a consistent
pain point for us. It does help to at least have the boost error code
logged to the journal. Ensure the error code is logged to the journal
consistently within the chassis file.

If this commit makes sense to the maintainers then I will work on making
this consistent in other files at a later date.

Tested:
- Verified it compiled and one of the error paths traced the appropriate
  boost error code.

Change-Id: I76b7644bc18e76fff69595fb5f1bc23d257563e9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

redfish-core/lib/chassis.hpp

diff --git a/redfish-core/lib/chassis.hpp b/redfish-core/lib/chassis.hpp
index 32eb29b..d5b8d1f 100644
--- a/redfish-core/lib/chassis.hpp
+++ b/redfish-core/lib/chassis.hpp
@@ -63,7 +63,7 @@
                 BMCWEB_LOG_DEBUG << "Service not available " << ec;
                 return;
             }
-            BMCWEB_LOG_DEBUG << "DBUS response error " << ec;
+            BMCWEB_LOG_ERROR << "DBUS response error " << ec;
             messages::internalError(aResp->res);
             return;
         }
@@ -184,7 +184,7 @@
                     const std::string& property) {
         if (ec)
         {
-            BMCWEB_LOG_DEBUG << "DBUS response error for Location";
+            BMCWEB_LOG_ERROR << "DBUS response error for Location";
             messages::internalError(asyncResp->res);
             return;
         }
@@ -205,7 +205,7 @@
                     const std::string& chassisUUID) {
         if (ec)
         {
-            BMCWEB_LOG_DEBUG << "DBUS response error for UUID";
+            BMCWEB_LOG_ERROR << "DBUS response error for UUID";
             messages::internalError(asyncResp->res);
             return;
         }
@@ -233,6 +233,7 @@
             const dbus::utility::MapperGetSubTreeResponse& subtree) {
         if (ec)
         {
+            BMCWEB_LOG_ERROR << "DBUS response error " << ec;
             messages::internalError(asyncResp->res);
             return;
         }
@@ -540,6 +541,7 @@
                        const dbus::utility::MapperGetSubTreeResponse& subtree) {
         if (ec)
         {
+            BMCWEB_LOG_ERROR << "DBUS response error " << ec;
             messages::internalError(asyncResp->res);
             return;
         }
@@ -644,7 +646,7 @@
             const dbus::utility::MapperGetSubTreePathsResponse& chassisList) {
         if (ec)
         {
-            BMCWEB_LOG_DEBUG << "[mapper] Bad D-Bus request error: " << ec;
+            BMCWEB_LOG_ERROR << "[mapper] Bad D-Bus request error: " << ec;
             messages::internalError(asyncResp->res);
             return;
         }
@@ -671,7 +673,7 @@
             // Use "Set" method to set the property value.
             if (ec2)
             {
-                BMCWEB_LOG_DEBUG << "[Set] Bad D-Bus request error: " << ec2;
+                BMCWEB_LOG_ERROR << "[Set] Bad D-Bus request error: " << ec2;
                 messages::internalError(asyncResp->res);
                 return;
             }