Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / bmcweb / 1530261b40a9cbe77f349e4b4ddff427cf626b66
commit1530261b40a9cbe77f349e4b4ddff427cf626b66[log] [tgz]
authorAdrian Ambrożewicz <adrian.ambrozewicz@linux.intel.com>Thu Jul 16 11:24:47 2020 +0200
committerAdrian Ambrożewicz <adrian.ambrozewicz@linux.intel.com>Fri Jul 17 13:28:28 2020 +0200
treea604de1e9a2a44617c4eaed0b0563c1cfbba10f8
parentb41187fac9d82be2ea26bd8695f2beba135e80f1 [diff]
Make default PUT handling return 403 for unpriviledged user

Default implementation for GET, POST, PATCH and DELETE returns 403
if user does not have right to perform action on a resource.
Access right was verified even if method was not implemented
(which is good).

PUT was lacking this behavior, and returned 405 (method not allowed)
for unpriviledged user if it was not supported by resource.

This change makes PUT method behaving the same way as the other in this
scenario, making behavior of all basic REST methods consistent.

Testing:
- verified that calling PUT for unpriviledged user on resource, that
  doesn't implement it, returns 403 instead of 405

Signed-off-by: Adrian Ambrożewicz <adrian.ambrozewicz@linux.intel.com>
Change-Id: I91ffb88755093b2d5d19f073407df6ede026d720
1 file changed
tree: a604de1e9a2a44617c4eaed0b0563c1cfbba10f8
  1. cmake/
  2. http/
  3. include/
  4. redfish-core/
  5. scripts/
  6. src/
  7. static/
  8. .clang-format
  9. .gitignore
  10. bmcweb.service.in
  11. bmcweb.socket
  12. build_x86.sh
  13. cmake-format.json
  14. CMakeLists.txt
  15. CMakeLists.txt.in
  16. config.h.in
  17. DEVELOPING.md
  18. JenkinsFile
  19. LICENCE
  20. MAINTAINERS
  21. pam-webserver
  22. README.md
  23. Redfish.md
README.md

OpenBMC webserver

This component attempts to be a "do everything" embedded webserver for openbmc.

Capabilities

At this time, the webserver implements a few interfaces:

  • Authentication middleware that supports cookie and token based authentication, as well as CSRF prevention backed by linux PAM authentication credentials.
  • An (incomplete) attempt at replicating phosphor-dbus-rest interfaces in C++. Right now, a few of the endpoint definitions work as expected, but there is still a lot of work to be done. The portions of the interface that are functional are designed to work correctly for phosphor-webui, but may not yet be complete.
  • Replication of the rest-dbus backend interfaces to allow bmc debug to logged in users.
  • An initial attempt at a read-only redfish interface. Currently the redfish interface targets ServiceRoot, SessionService, AccountService, Roles, and ManagersService. Some functionality here has been shimmed to make development possible. For example, there exists only a single user role.
  • SSL key generation at runtime. See the configuration section for details.
  • Static file hosting. Currently, static files are hosted from the fixed location at /usr/share/www. This is intended to allow loose coupling with yocto projects, and allow overriding static files at build time.
  • Dbus-monitor over websocket. A generic endpoint that allows UIs to open a websocket and register for notification of events to avoid polling in single page applications. (this interface may be modified in the future due to security concerns.

Configuration

BMCWeb is configured by setting -D flags that correspond to options in bmcweb/CMakeLists.txt and then compiling. For example, cmake -DBMCWEB_ENABLE_KVM=NO ... followed by make. The option names become C++ preprocessor symbols that control which code is compiled into the program.

When BMCWeb starts running, it reads persistent configuration data (such as UUID and session data) from a local file. If this is not usable, it generates a new configuration.

When BMCWeb SSL support is enabled and a usable certificate is not found, it will generate a self-sign a certificate before launching the server. The keys are generated by the secp384r1 algorithm. The certificate

  • is issued by C=US, O=OpenBMC, CN=testhost,
  • is valid for 10 years,
  • has a random serial number, and
  • is signed using the SHA-256 algorithm.