commit 5611d5485a9543c7a745814d8d7bdaf4dc1b7836
author Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com> Sat Apr 23 00:43:22 2022 +0200
committer Ed Tanous <ed@tanous.net> Fri Apr 29 22:39:03 2022 +0000
tree f04e490a45e61608f41f77f0404ae584c6d3c4e2
parent 670eacaeccbf37aef4ff21e960c40247c5a07efc

Fix unmounting image in proxy mode.

Sometimes Slot0 got higher key than Slot1 and erase function for Slot1
invalidates elements with keys not less than the erased element.
In that case invalid slot0 will be unmounted.
Change order of calling close() and erase() functions to
unmount correct device.

Change-Id: I7a40a4518982f697d3eed635cde6d06978149cf0
Signed-off-by: Alicja Rybak <alicja.rybak@intel.com>
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>

include/nbd_proxy.hpp

diff --git a/include/nbd_proxy.hpp b/include/nbd_proxy.hpp
index 7b765e2..97c8b57 100644
--- a/include/nbd_proxy.hpp
+++ b/include/nbd_proxy.hpp
@@ -413,9 +413,9 @@
                     BMCWEB_LOG_DEBUG << "No session to close";
                     return;
                 }
+                session->second->close();
                 // Remove reference to session in global map
                 sessions.erase(session);
-                session->second->close();
             })
         .onmessage([](crow::websocket::Connection& conn,
                       const std::string& data, bool) {