Enable 3 member function checks
The only changes were to make some functions static, which is
essentially no-op.
Changes were done by the robot.
Tested: Unit tests pass, changes no-op
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id84ca2bee6f237877ba2900b2cbe4679b38a91dc
diff --git a/.clang-tidy b/.clang-tidy
index 6412a66..dfca83a 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -272,11 +272,14 @@
readability-braces-around-statements,
readability-const-return-type,
readability-container-size-empty,
+readability-convert-member-functions-to-static,
readability-delete-null-pointer,
readability-deleted-default,
readability-else-after-return,
readability-implicit-bool-conversion,
+readability-make-member-function-const,
readability-named-parameter,
+readability-non-const-parameter,
readability-redundant-control-flow,
readability-redundant-declaration,
readability-redundant-function-ptr-dereference,
diff --git a/include/multipart_parser.hpp b/include/multipart_parser.hpp
index ee028f1..945ebf9 100644
--- a/include/multipart_parser.hpp
+++ b/include/multipart_parser.hpp
@@ -219,7 +219,7 @@
}
}
- char lower(char c) const
+ static char lower(char c)
{
return static_cast<char>(c | 0x20);
}
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp
index 6cb95c4..e6e694f 100644
--- a/redfish-core/include/event_service_manager.hpp
+++ b/redfish-core/include/event_service_manager.hpp
@@ -663,7 +663,7 @@
}
}
- void loadOldBehavior()
+ static void loadOldBehavior()
{
std::ifstream eventConfigFile(eventServiceFile);
if (!eventConfigFile.good())
@@ -1312,8 +1312,14 @@
}
#endif
- void getReadingsForReport(sdbusplus::message::message& msg)
+ static void getReadingsForReport(sdbusplus::message::message& msg)
{
+ if (msg.is_method_error())
+ {
+ BMCWEB_LOG_ERROR << "TelemetryMonitor Signal error";
+ return;
+ }
+
sdbusplus::message::object_path path(msg.get_path());
std::string id = path.filename();
if (id.empty())
@@ -1380,16 +1386,7 @@
"arg0=xyz.openbmc_project.Telemetry.Report";
matchTelemetryMonitor = std::make_shared<sdbusplus::bus::match::match>(
- *crow::connections::systemBus, matchStr,
- [this](sdbusplus::message::message& msg) {
- if (msg.is_method_error())
- {
- BMCWEB_LOG_ERROR << "TelemetryMonitor Signal error";
- return;
- }
-
- getReadingsForReport(msg);
- });
+ *crow::connections::systemBus, matchStr, getReadingsForReport);
}
};
diff --git a/redfish-core/include/gzfile.hpp b/redfish-core/include/gzfile.hpp
index 567741d..696b13c 100644
--- a/redfish-core/include/gzfile.hpp
+++ b/redfish-core/include/gzfile.hpp
@@ -38,7 +38,7 @@
std::string lastDelimiter;
size_t totalFilesSize = 0;
- void printErrorMessage(gzFile logStream)
+ static void printErrorMessage(gzFile logStream)
{
int errNum = 0;
const char* errMsg = gzerror(logStream, &errNum);
diff --git a/redfish-core/lib/task.hpp b/redfish-core/lib/task.hpp
index b7795a7..4ebbc14 100644
--- a/redfish-core/lib/task.hpp
+++ b/redfish-core/lib/task.hpp
@@ -188,7 +188,7 @@
});
}
- void sendTaskEvent(const std::string_view state, size_t index)
+ static void sendTaskEvent(const std::string_view state, size_t index)
{
std::string origin =
"/redfish/v1/TaskService/Tasks/" + std::to_string(index);