commit 56d2396d090ee873d58c58737382758d2afea8b9
author Ed Tanous <edtanous@google.com> Mon Feb 14 20:42:02 2022 -0800
committer Ed Tanous <edtanous@google.com> Wed Mar 09 09:21:15 2022 -0800
tree e6aa06c41dcd7495380c54c88840b5b37d71da26
parent 5f2b84ee090bb9d361de9c294aa85cecf3962c11

Enable 3 member function checks

The only changes were to make some functions static, which is
essentially no-op.

Changes were done by the robot.

Tested: Unit tests pass, changes no-op

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id84ca2bee6f237877ba2900b2cbe4679b38a91dc

redfish-core/include/event_service_manager.hpp

diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp
index 6cb95c4..e6e694f 100644
--- a/redfish-core/include/event_service_manager.hpp
+++ b/redfish-core/include/event_service_manager.hpp
@@ -663,7 +663,7 @@
         }
     }
 
-    void loadOldBehavior()
+    static void loadOldBehavior()
     {
         std::ifstream eventConfigFile(eventServiceFile);
         if (!eventConfigFile.good())
@@ -1312,8 +1312,14 @@
     }
 
 #endif
-    void getReadingsForReport(sdbusplus::message::message& msg)
+    static void getReadingsForReport(sdbusplus::message::message& msg)
     {
+        if (msg.is_method_error())
+        {
+            BMCWEB_LOG_ERROR << "TelemetryMonitor Signal error";
+            return;
+        }
+
         sdbusplus::message::object_path path(msg.get_path());
         std::string id = path.filename();
         if (id.empty())
@@ -1380,16 +1386,7 @@
                                "arg0=xyz.openbmc_project.Telemetry.Report";
 
         matchTelemetryMonitor = std::make_shared<sdbusplus::bus::match::match>(
-            *crow::connections::systemBus, matchStr,
-            [this](sdbusplus::message::message& msg) {
-                if (msg.is_method_error())
-                {
-                    BMCWEB_LOG_ERROR << "TelemetryMonitor Signal error";
-                    return;
-                }
-
-                getReadingsForReport(msg);
-            });
+            *crow::connections::systemBus, matchStr, getReadingsForReport);
     }
 };
 

redfish-core/include/gzfile.hpp

diff --git a/redfish-core/include/gzfile.hpp b/redfish-core/include/gzfile.hpp
index 567741d..696b13c 100644
--- a/redfish-core/include/gzfile.hpp
+++ b/redfish-core/include/gzfile.hpp
@@ -38,7 +38,7 @@
     std::string lastDelimiter;
     size_t totalFilesSize = 0;
 
-    void printErrorMessage(gzFile logStream)
+    static void printErrorMessage(gzFile logStream)
     {
         int errNum = 0;
         const char* errMsg = gzerror(logStream, &errNum);