tree ccb41d298191ca90f41d7b234ebe4532abb1dfb8
parent db18fc98241b4fc9a4274f45c1d6b07d7bd1b93d
author Johnathan Mantey <johnathanx.mantey@intel.com> 1660599516 -0700
committer Ed Tanous <ed@tanous.net> 1661828197 +0000

Report MACAddress is read-only for a D-Bus Not Allowed response

The BMC Manager MACAddress ethernet property is a Read/Write property
in the Redfish spec. There are OpenBMC users that configure the
property to be Read Only. The phosphor-network build includes a
'persist-mac' configuration switch which controls MAC address
assignment. An attempt to set a R/O MACAddress causes D-Bus to return
an error. The exact error is available in a sdbus message.

The EthernetInterface XML indicates this is acceptable behavior:
"If an assignable MAC address is not supported, this value is a
read-only alias of the PermanentMACAddress."

As this condition is considered proper behavior it is incorrect to
return an internalError(). It is better behavior to return a
"Read-only" error message.

Tested:
Performed a Redfish PATCH for the MACAddress property.
The PATCH command returns a 403 error code, and a message body
indicating that the MACAddress is not writable.

Change-Id: Ice97affe694f4bee15436293c9e5944bcae7f4cc
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>