tree e7a23615da111f1eb89349cea98182665ca5bd95
parent 9896eaed88332eca7334a564a2ea2e0baf135639
author Asmitha Karunanithi <asmitk01@in.ibm.com> 1634883461 -0500
committer Ed Tanous <ed@tanous.net> 1659714337 +0000

Return proper redfish errors for createDump call

Currently, only internal server error will be returned to a client when
there is a create dump dbus call failure in the backend, irrespective
of the error that's returned by the phosphor-dump-manager.

This change will send a proper error response to the user based on the
host state.

Tested By:

curl -k -H "X-Auth-Token: $bmc_token" -X POST https://${bmc}
/redfish/v1/Systems/system/LogServices/Dump/Actions/
LogService.CollectDiagnosticData -d
'{"DiagnosticDataType":"OEM", "OEMDiagnosticDataType":"Resource_vps_str"}'
{
  "error": {
    "@Message.ExtendedInfo": [
      {
        "@odata.type": "#Message.v1_1_1.Message",
        "Message": "The request could not be performed because the resource is in standby.",
        "MessageArgs": [],
        "MessageId": "Base.1.8.1.ResourceInStandby",
        "MessageSeverity": "Critical",
        "Resolution": "Ensure that the resource is in the correct power state and resubmit the request."
      }
    ],
    "code": "Base.1.8.1.ResourceInStandby",
    "message": "The request could not be performed because the resource is in standby."
  }
}

curl -k -H "X-Auth-Token: $bmc_token" -X POST
https://${bmc}/redfish/v1/Managers/bmc/LogServices/
Dump/Actions/LogService.CollectDiagnosticData -d '{"DiagnosticDataType":"Manager"}'
{
  "error": {
    "@Message.ExtendedInfo": [
      {
        "@odata.type": "#Message.v1_1_1.Message",
        "Message": "The operation failed because the service at /redfish/v1/Managers/bmc/LogServices/Dump/ is disabled and cannot accept requests.",
        "MessageArgs": [
          "/redfish/v1/Managers/bmc/LogServices/Dump/"
        ],
        "MessageId": "Base.1.11.0.ServiceDisabled",
        "MessageSeverity": "Warning",
        "Resolution": "Enable the service and resubmit the request if the operation failed."
      }
    ],
    "code": "Base.1.11.0.ServiceDisabled",
    "message": "The operation failed because the service at /redfish/v1/Managers/bmc/LogServices/Dump/ is disabled and cannot accept requests."
  }
}

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ica087e4cac2beeded896f0c83c9481f8164d2c62