Move where appropriate
Clang-tidy-18 has new checks that can find more cases where we've
missed an opportunity to std::move.
Fix them.
Tested: Logging works, unit tests pass.
Change-Id: I0cf58204ce7265828693b787a7b3a16484c3d5e5
Signed-off-by: Ed Tanous <ed@tanous.net>
diff --git a/.clang-tidy b/.clang-tidy
index ca103f3..5b530c3 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -357,4 +357,5 @@
- { key: readability-identifier-naming.FunctionIgnoredRegexp, value: (BMCWEB_LOG_DEBUG|BMCWEB_LOG_INFO|BMCWEB_LOG_WARNING|BMCWEB_LOG_ERROR|BMCWEB_LOG_CRITICAL) }
- { key: cppcoreguidelines-macro-usage.AllowedRegexp, value: DEBUG*|NLOHMANN_JSON_SERIALIZE_ENUM }
- { key: performance-unnecessary-value-param.AllowedTypes, value: ((segments_view)|(url_view)) }
+ - { key: cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams, value: true }
- { key: misc-include-cleaner.IgnoreHeaders, value: ((nlohmann/json_fwd.hpp)|(boost/.*/src.hpp)|(boost/.*/detail/.*)|(nlohmann/detail/.*)|(stdio.h)|(ranges)|(bits/chrono.h)|(boost/system/error_code.hpp)) }
diff --git a/http/utility.hpp b/http/utility.hpp
index 47ddaf9..0476d73 100644
--- a/http/utility.hpp
+++ b/http/utility.hpp
@@ -439,7 +439,7 @@
};
inline bool readUrlSegments(boost::urls::url_view url,
- std::initializer_list<UrlSegment>&& segments)
+ std::initializer_list<UrlSegment> segments)
{
boost::urls::segments_view urlSegments = url.segments();
diff --git a/redfish-core/include/utils/json_utils.hpp b/redfish-core/include/utils/json_utils.hpp
index c8af2d1..0f4ba06 100644
--- a/redfish-core/include/utils/json_utils.hpp
+++ b/redfish-core/include/utils/json_utils.hpp
@@ -542,7 +542,8 @@
messages::unrecognizedRequestBody(res);
return false;
}
- return readJsonObject(*obj, res, key, first, in...);
+ return readJsonObject(*obj, res, key, std::forward<FirstType>(first),
+ std::forward<UnpackTypes&&>(in)...);
}
inline std::optional<nlohmann::json::object_t>