commit 5e7e2dc585dc7a7e62d2b648b541e7f50c39ea5d
author Ed Tanous <edtanous@google.com> Thu Feb 16 10:37:01 2023 -0800
committer Ed Tanous <ed@tanous.net> Fri Feb 24 17:21:40 2023 +0000
tree ee3993e0fb2dc6e244a5fc31c7e83b26783161ee
parent 26ccae32112679c4653c1e3f8a1203c828bea05c

Take boost error_code by reference

By convention, we should be following boost here, and passing error_code
by reference, not by value.  This makes our code consistent, and removes
the need for a copy in some cases.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id42ea4a90b6685a84818b87d1506c11256b3b9ae

include/google/google_service_root.hpp

diff --git a/include/google/google_service_root.hpp b/include/google/google_service_root.hpp
index d5d340a..cbcf15d 100644
--- a/include/google/google_service_root.hpp
+++ b/include/google/google_service_root.hpp
@@ -65,7 +65,7 @@
     const std::string& command,
     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
     const std::string& rotId, const ResolvedEntityHandler& entityHandler,
-    const boost::system::error_code ec,
+    const boost::system::error_code& ec,
     const dbus::utility::MapperGetSubTreeResponse& subtree)
 {
     if (ec)
@@ -147,7 +147,7 @@
 
 inline void
     invocationCallback(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
-                       const boost::system::error_code ec,
+                       const boost::system::error_code& ec,
                        const std::vector<uint8_t>& responseBytes)
 {
     if (ec)
@@ -177,7 +177,7 @@
     }
 
     crow::connections::systemBus->async_method_call(
-        [asyncResp{asyncResp}](const boost::system::error_code ec,
+        [asyncResp{asyncResp}](const boost::system::error_code& ec,
                                const std::vector<uint8_t>& responseBytes) {
         invocationCallback(asyncResp, ec, responseBytes);
         },