Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / bmcweb / 5eb2bef287eff01515671f07148393ceb9c5cad6
commit5eb2bef287eff01515671f07148393ceb9c5cad6[log] [tgz]
authorAppaRao Puli <apparao.puli@linux.intel.com>Mon Dec 16 19:35:39 2019 +0530
committerAppaRao Puli <apparao.puli@linux.intel.com>Tue Dec 17 18:57:38 2019 +0000
tree6df333372cc3766f602f62e42f90b9e9aad9ad1d
parent61dbeef97168db1a1f7a351c5f95e09afd361e48 [diff]
Fix: bug fixes in readJson

This commit contains bug fixes in readJson function call
 1) Handled invalid double value which is leading to crash
    bmcweb. If user give string for double value key, its
    not handled in readJson which intern causes exception
    and crash.
 2) If any of input types of floating_point, signed or unsigned
    int type values are provided with wrong type, it should
    return error, instead its returning 200 success response.
    Added code to return proper error response.

Tested:
 - Tested invalid case by giving wrong type values in PATCH.
URI: /redfish/v1/Chassis/WC_Baseboard/Thermal
METHOD: Patch
REQUEST:
{
"Fans": [
    {
      "MemberId": "Fan_1a",
      "Reading": "200"
    }
  ]
}
RESPONSE:
{
  "Reading@Message.ExtendedInfo": [
    {
      "@odata.type": "/redfish/v1/$metadata#Message.v1_0_0.Message",
      "Message": "The value \"200\" for the property Reading is of a different type than the property can accept.",
      "MessageArgs": [
        "\"200\"",
        "Reading"
      ],
      "MessageId": "Base.1.4.0.PropertyValueTypeError",
      "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed.",
      "Severity": "Warning"
    }
  ]
}

 - Also performed some positive and negative tests with other URI's.
 - Redfish validator ran successfully without any issue(No impact though)

Change-Id: Ie98384e67a863ab96aa537f492a686b2c7ebb3a2
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
1 file changed
tree: 6df333372cc3766f602f62e42f90b9e9aad9ad1d
  1. cmake/
  2. http/
  3. include/
  4. redfish-core/
  5. scripts/
  6. src/
  7. static/
  8. .clang-format
  9. .gitignore
  10. bmcweb.service.in
  11. bmcweb.socket
  12. build_x86.sh
  13. cmake-format.json
  14. CMakeLists.txt
  15. CMakeLists.txt.in
  16. DEVELOPING.md
  17. JenkinsFile
  18. LICENCE
  19. MAINTAINERS
  20. pam-webserver
  21. README.md
  22. Redfish.md
README.md

OpenBMC webserver

This component attempts to be a "do everything" embedded webserver for openbmc.

Capabilities

At this time, the webserver implements a few interfaces:

  • Authentication middleware that supports cookie and token based authentication, as well as CSRF prevention backed by linux PAM authentication credentials.
  • An (incomplete) attempt at replicating phosphor-dbus-rest interfaces in C++. Right now, a few of the endpoint definitions work as expected, but there is still a lot of work to be done. The portions of the interface that are functional are designed to work correctly for phosphor-webui, but may not yet be complete.
  • Replication of the rest-dbus backend interfaces to allow bmc debug to logged in users.
  • An initial attempt at a read-only redfish interface. Currently the redfish interface targets ServiceRoot, SessionService, AccountService, Roles, and ManagersService. Some functionality here has been shimmed to make development possible. For example, there exists only a single user role.
  • SSL key generation at runtime. See the configuration section for details.
  • Static file hosting. Currently, static files are hosted from the fixed location at /usr/share/www. This is intended to allow loose coupling with yocto projects, and allow overriding static files at build time.
  • Dbus-monitor over websocket. A generic endpoint that allows UIs to open a websocket and register for notification of events to avoid polling in single page applications. (this interface may be modified in the future due to security concerns.

Configuration

BMCWeb is configured by setting -D flags that correspond to options in bmcweb/CMakeLists.txt and then compiling. For example, cmake -DBMCWEB_ENABLE_KVM=NO ... followed by make. The option names become C++ preprocessor symbols that control which code is compiled into the program.

When BMCWeb starts running, it reads persistent configuration data (such as UUID and session data) from a local file. If this is not usable, it generates a new configuration.

When BMCWeb SSL support is enabled and a usable certificate is not found, it will generate a self-sign a certificate before launching the server. The keys are generated by the prime256v1 algorithm. The certificate

  • is issued by C=US, O=OpenBMC, CN=testhost,
  • is valid for 10 years,
  • has a random serial number, and
  • is signed using the SHA-256 algorithm.