tree 01694d4501e0bf3a734dea0e1c52ec8a7e7c819b
parent 13451e3913c29bb380ef6778f11749d337ddd442
author Ninad Palsule <ninadpalsule@us.ibm.com> 1682021481 -0500
committer Ed Tanous <edtanous@google.com> 1685564873 -0700

Disabled processor and memory summary status

Redfish deprecated the Processor/Memory Summary Status (state, health,
healthrollup) attributes. Please refer to redfish spec for more details:
https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_20_0.json

Initially I tried to fix the summary status issues,
(https://gerrit.openbmc.org/c/openbmc/bmcweb/+/60663)
But later it was decided that we should also remove these attributes
from the bmcweb code. Here is a link to discussion on discord:
https://discord.com/channels/775381525260664832/855566794994221117/1093939076710793296

This drop hides these attributes under defined
BMCWEB_ENABLE_PROC_MEM_STATUS. This option is disabled by default.

These attributes will be permanently removed from code in 1Q 2024
(in 8-9 months).

Testing:
  - Redfish validator passed excepted couple of failures but those are
    failing without my changes too.
  - Make sure that summary status for memory and processor is not seen
    in the output.

    Without fix:
    ------------
    '''
    $ curl -s -k https://${bmc}/redfish/v1/Systems/system
    .....
    "MemorySummary": {
      "Status": {
        "Health": "OK",
        "HealthRollup": "OK",
        "State": "Enabled"
      },
      "TotalSystemMemoryGiB": 256
    },
    .....
    "ProcessorSummary": {
      "CoreCount": 20,
      "Count": 4,
      "Status": {
        "Health": "OK",
        "HealthRollup": "OK",
        "State": "Enabled"
      }
    },
    .....
    ''''

    With fix:
    ---------
    '''
    "MemorySummary": {
      "TotalSystemMemoryGiB": 256
    },
    .....
    "ProcessorSummary": {
      "CoreCount": 20,
      "Count": 4
    },
    .....
    ''''
  - Turned on BMCWEB_ALLOW_DEPRECATED_PROC_MEM_STATUS flag and made sure
    that properties are shown again.

Change-Id: I1e0ee386bd4f365599afcf46e5d587285af635ad
Signed-off-by: Ninad Palsule <ninadpalsule@us.ibm.com>
Signed-off-by: Ed Tanous <edtanous@google.com>