commit 601af5ed832deae3f525064d94bb5a65b04554ae
author Chicago Duan <duanzhijia01@inspur.com> Thu Apr 15 16:59:25 2021 +0800
committer Gunnar Mills <gmills@us.ibm.com> Wed Apr 21 03:37:18 2021 +0000
tree 7a58a7841cad87ca5d02ebed98f075683a95a668
parent d51e072fa60348422d6a145d76d7506de2bca4d6

Redfish : Return after InternalError instead of Continue

"After setting response to internal error you should stop adding more content to response. Try to return instead of continuing a loop"

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39970/9/redfish-core/lib/pcie_slots.hpp#169

Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: Iadd3062ba7fef31ba61eea1e79eb3a903716b9e9

redfish-core/lib/storage.hpp

diff --git a/redfish-core/lib/storage.hpp b/redfish-core/lib/storage.hpp
index c2651d5..34ef39a 100644
--- a/redfish-core/lib/storage.hpp
+++ b/redfish-core/lib/storage.hpp
@@ -239,7 +239,7 @@
                                     {
                                         // illegal property
                                         messages::internalError(asyncResp->res);
-                                        continue;
+                                        return;
                                     }
                                     object[propertyName] = *value;
                                 }
@@ -385,7 +385,7 @@
                                 {
                                     // illegal property
                                     messages::internalError(asyncResp->res);
-                                    continue;
+                                    return;
                                 }
                                 asyncResp->res.jsonValue[propertyName] = *value;
                             }