commit 6145ed6f329d492ec074e24134368a70549a782c
author Asmitha Karunanithi <asmitk01@in.ibm.com> Thu Sep 17 23:40:03 2020 -0500
committer Asmitha Karunanithi <asmitk01@in.ibm.com> Sun Sep 27 03:15:54 2020 -0500
tree 09cc1e2676992a0e0ec60781637e67bc0890229a
parent d337bb7249e6791d7fc3769e3d8e1ed64c563608

Fix Task related issue when creating a bmc dump

This commit fixes the issue where, while creating a
bmc dump, the task was not being sent back to the
redfish client as the response.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Id3d6466c5bfc04aa44a66f53e35c4ea28f8ae25b

redfish-core/lib/log_services.hpp

diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index f354f63..5c16cad 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -714,13 +714,14 @@
                                    const std::string& dumpType)
 {
     std::shared_ptr<task::TaskData> task = task::TaskData::createTask(
-        [dumpId, dumpPath, dumpType, asyncResp](
+        [dumpId, dumpPath, dumpType](
             boost::system::error_code err, sdbusplus::message::message& m,
             const std::shared_ptr<task::TaskData>& taskData) {
             if (err)
             {
-                messages::internalError(asyncResp->res);
-                return false;
+                BMCWEB_LOG_ERROR << "Error in creating a dump";
+                taskData->state = "Cancelled";
+                return task::completed;
             }
             std::vector<std::pair<
                 std::string,
@@ -745,10 +746,10 @@
                         std::move(headerLoc));
 
                     taskData->state = "Completed";
-                    return task::completed;
+                    break;
                 }
             }
-            return !task::completed;
+            return task::completed;
         },
         "type='signal',interface='org.freedesktop.DBus."
         "ObjectManager',"