clang-tidy: fix misc warnings
The following error reports have started to be reported by clang-tidy:
* readability-qualified-auto - add 'const' to `auto&` iterators
* bugprone-use-after-move - add break in loop after element is found
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5314559f62f58aa032d4c74946b8e3e4ce6be808
diff --git a/include/dbus_monitor.hpp b/include/dbus_monitor.hpp
index 129422e..5f409d7 100644
--- a/include/dbus_monitor.hpp
+++ b/include/dbus_monitor.hpp
@@ -84,7 +84,7 @@
}
// data is type oa{sa{sv}} which is an array[2] of string, object
- for (auto& entry : data[1].items())
+ for (const auto& entry : data[1].items())
{
auto it = thisSession->second.interfaces.find(entry.key());
if (it != thisSession->second.interfaces.end())
diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp
index d8a4e66..95503d7 100644
--- a/include/openbmc_dbus_rest.hpp
+++ b/include/openbmc_dbus_rest.hpp
@@ -1768,7 +1768,7 @@
}
else
{
- for (auto& prop : properties.items())
+ for (const auto& prop : properties.items())
{
// if property name is empty, or
// matches our search query, add it