commit 634a5e0a0653503df210923b512cbd4bf09c7499
author Ed Tanous <etanous@nvidia.com> Fri Sep 26 12:05:08 2025 -0700
committer Ed Tanous <ed@tanous.net> Tue Sep 30 01:24:28 2025 +0000
tree 4d3ad10e79f39a55f6aa67ff5c5048cdde062d22
parent de5259d11d1f932fc87f3720d49914a42f8d2c59

Make unit tests use arrays

When these tests hit failures, splitting up these frames makes it a lot
easier to debug.

Tested: Unit tests pass

Change-Id: I29f5906c2f7aa90d0bd9989ba9f9d2525987f4d9
Signed-off-by: Ed Tanous <etanous@nvidia.com>

test/http/http2_connection_test.cpp

diff --git a/test/http/http2_connection_test.cpp b/test/http/http2_connection_test.cpp
index 117ae45..9c36a43 100644
--- a/test/http/http2_connection_test.cpp
+++ b/test/http/http2_connection_test.cpp
@@ -19,6 +19,7 @@
 #include <boost/asio/write.hpp>
 #include <boost/beast/http/field.hpp>
 
+#include <array>
 #include <bit>
 #include <cstddef>
 #include <cstdint>
@@ -133,18 +134,19 @@
         &handler, date, HttpType::HTTP, nullptr);
     conn->start();
 
-    std::string_view expectedPrefix =
+    std::array<std::string_view, 5> expectedPrefix = {
         // Settings frame size 13
-        "\x00\x00\x0c\x04\x00\x00\x00\x00\x00"
+        "\x00\x00\x0c\x04\x00\x00\x00\x00\x00"sv,
         // 4 max concurrent streams
-        "\x00\x03\x00\x00\x00\x04"
+        "\x00\x03\x00\x00\x00\x04"sv,
         // Enable push = false
-        "\x00\x02\x00\x00\x00\x00"
+        "\x00\x02\x00\x00\x00\x00"sv,
         // Settings ACK from server to client
-        "\x00\x00\x00\x04\x01\x00\x00\x00\x00"
+        "\x00\x00\x00\x04\x01\x00\x00\x00\x00"sv,
 
         // Start Headers frame stream 1, size 0x005f
-        "\x00\x00\x5f\x01\x04\x00\x00\x00\x01"sv;
+        "\x00\x00\x5f\x01\x04\x00\x00\x00\x01"sv,
+    };
 
     std::string_view expectedPostfix =
         // Data Frame, Length 12, Stream 1, End Stream flag set
@@ -155,9 +157,14 @@
     std::string_view outStr;
     constexpr size_t headerSize = 0x05f;
 
+    size_t expectedPrefixSize = 0;
+    for (const auto prefix : expectedPrefix)
+    {
+        expectedPrefixSize += prefix.size();
+    }
     // Run until we receive the expected amount of data
     while (outStr.size() <
-           expectedPrefix.size() + headerSize + expectedPostfix.size())
+           expectedPrefixSize + headerSize + expectedPostfix.size())
     {
         io.run_one();
         outStr = out.str();
@@ -165,8 +172,12 @@
     EXPECT_TRUE(handler.called);
 
     // check the stream output against expected
-    EXPECT_EQ(outStr.substr(0, expectedPrefix.size()), expectedPrefix);
-    outStr.remove_prefix(expectedPrefix.size());
+    for (const auto& prefix : expectedPrefix)
+    {
+        EXPECT_EQ(outStr.substr(0, prefix.size()), prefix);
+        outStr.remove_prefix(prefix.size());
+    }
+
     std::vector<std::pair<std::string, std::string>> headers;
     unpackHeaders(outStr.substr(0, headerSize), headers);
     outStr.remove_prefix(headerSize);