tree 80008e0254238726d810aa92e3b62f9296e74e8d
parent 7d1cc387d312e2a8e4844f9d69ab39b042acd5ce
author Gunnar Mills <gmills@us.ibm.com> 1589749591 -0500
committer Gunnar Mills <gmills@us.ibm.com> 1590084934 +0000

Redfish: Set AutomaticRetry (AutoReboot)

"AutomaticRetryConfig" can be 3 values, Disabled, RetryAlways, and
RetryAttempts. OpenBMC only supports Disabled and RetryAttempts.
Use AllowableValues to show this.

"AutomaticRetryAttempts" is hardcoded in OpenBMC.
"RemainingAutomaticRetryAttempts" is readonly in Redfish.

Tested: Validator passes.
        PATCHing "Boot" "BootSourceOverrideEnabled" and
        "BootSourceOverrideTarget" still work.

curl -k https://$bmc/redfish/v1/Systems/system
...
  "Boot": {
    "AutomaticRetryAttempts": 3,
    "AutomaticRetryConfig": "RetryAttempts",
    "AutomaticRetryConfig@Redfish.AllowableValues": [
      "Disabled",
      "RetryAttempts"
    ],

Can see the following two set correctly on Redfish and D-Bus:
curl -k -v  -X PATCH https://${bmc}/redfish/v1/Systems/system -d \
'{"Boot":{"AutomaticRetryConfig": "Disabled"}}'
...
< HTTP/1.1 204 No Content

curl -k -v  -X PATCH https://${bmc}/redfish/v1/Systems/system -d \
'{"Boot":{"AutomaticRetryConfig": "RetryAttempts"}}'
...
< HTTP/1.1 204 No Content

Handles bad data:
curl -k -v  -X PATCH https://${bmc}/redfish/v1/Systems/system -d \
'{"Boot":{"AutomaticRetryConfig": "BadValue"}}'
...

< HTTP/1.1 400 Bad Request
...
  "AutomaticRetryConfig@Message.ExtendedInfo": [
    {
      "@odata.type": "#Message.v1_0_0.Message",
      "Message": "The value BadValue for the property AutomaticRetryConfig is not in the list of acceptable values.",
      "MessageArgs": [
        "BadValue",
        "AutomaticRetryConfig"
      ],
      "MessageId": "Base.1.4.0.PropertyValueNotInList",

Change-Id: I603ccce1a682ac40f2e496cba9172e2a6dfdb58d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>