commit 69fca03e92f1b96e1c02173d37742d74aeb9cb21
author Carson Labrado <clabrado@google.com> Fri Nov 04 18:10:15 2022 +0000
committer Ed Tanous <ed@tanous.net> Fri Nov 11 00:29:47 2022 +0000
tree 96d171b38479f0e10d5214c9f687682a5e3f1e7d
parent 32d9a653b253e963eab9c9d49a377d4d48e9ea8a

Aggregation: Fix header clobbering

We attempt to sanitize the response body of the asyncResp object as
the first step of copying over the satellite response into the
object.  This is clobbering the "OData-Version" from the response
header.

We can completely remove this step since the body will already be
empty.

Tested:
OData-Version is still present in the header when querying a satellite
resource
curl -s -D- localhost/redfish/v1/Chassis/5B247A_test | grep OData
OData-Version: 4.0

Signed-off-by: Carson Labrado <clabrado@google.com>
Change-Id: I82f54ae9b990504a3236b7a1273c794b1ee6f090

redfish-core/include/redfish_aggregator.hpp

diff --git a/redfish-core/include/redfish_aggregator.hpp b/redfish-core/include/redfish_aggregator.hpp
index b50b775..b91498e 100644
--- a/redfish-core/include/redfish_aggregator.hpp
+++ b/redfish-core/include/redfish_aggregator.hpp
@@ -604,9 +604,6 @@
 
             BMCWEB_LOG_DEBUG << "Added prefix to parsed satellite response";
 
-            asyncResp->res.stringResponse.emplace(
-                boost::beast::http::response<
-                    boost::beast::http::string_body>{});
             asyncResp->res.result(resp.result());
             asyncResp->res.jsonValue = std::move(jsonVal);
 
@@ -690,9 +687,6 @@
 
                 BMCWEB_LOG_DEBUG
                     << "Collection does not exist, overwriting asyncResp";
-                asyncResp->res.stringResponse.emplace(
-                    boost::beast::http::response<
-                        boost::beast::http::string_body>{});
                 asyncResp->res.result(resp.result());
                 asyncResp->res.jsonValue = std::move(jsonVal);