Change query param errors to be 400 instead of 403
Any query param errors from the base registry being sent imply that the
user-provided parameters were bad, which should return bad request, not
forbidden. This is in line with the spec.
Luckily, the only usage of these parameters as of now is from within the
query params support model, so changing it shouldn't cause any backward
compatibility issues, and because these are meant for "bad request" type
messages, it's unlikely it would even be able to effect clients.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I13a4601d1236d9eaac6bbf5fb25e0f1b28c04a21
diff --git a/redfish-core/src/error_messages.cpp b/redfish-core/src/error_messages.cpp
index 6353167..95bbea7 100644
--- a/redfish-core/src/error_messages.cpp
+++ b/redfish-core/src/error_messages.cpp
@@ -1441,7 +1441,7 @@
void queryNotSupportedOnResource(crow::Response& res)
{
- res.result(boost::beast::http::status::forbidden);
+ res.result(boost::beast::http::status::bad_request);
addMessageToErrorJson(res.jsonValue, queryNotSupportedOnResource());
}
@@ -1460,7 +1460,7 @@
void queryNotSupportedOnOperation(crow::Response& res)
{
- res.result(boost::beast::http::status::forbidden);
+ res.result(boost::beast::http::status::bad_request);
addMessageToErrorJson(res.jsonValue, queryNotSupportedOnOperation());
}