Rework logger to create compile time errors
The logger changes to move to std::format incidentally caused format
errors to no longer be flagged at compile time.
The example here[1] shows that the latest gcc/c++ gave us a way to solve
this, using std::format_string.
This incidentally shows two places where we got the format arguments
wrong, so fix them.
[1] https://stackoverflow.com/questions/72795189/how-can-i-wrap-stdformat-with-my-own-template-function
Change-Id: Id884200e2c98eeaf5ef8db6c1d6362ede2ffb858
Signed-off-by: Ed Tanous <ed@tanous.net>
diff --git a/http/http_client.hpp b/http/http_client.hpp
index 2d03487..5980478 100644
--- a/http/http_client.hpp
+++ b/http/http_client.hpp
@@ -790,8 +790,7 @@
{
// If we can't buffer the request then we should let the
// callback handle a 429 Too Many Requests dummy response
- BMCWEB_LOG_ERROR("{}:{} request queue full. Dropping request.",
- id);
+ BMCWEB_LOG_ERROR("{} request queue full. Dropping request.", id);
Response dummyRes;
dummyRes.result(boost::beast::http::status::too_many_requests);
resHandler(dummyRes);