Add Health information for FabricAdapter
This commit is to add health information according to the Redfish
FabricAdapter schema. If the
`xyz.openbmc_project.State.Decorator.OperationalStatus` interface does
not exist, the health information property is not displayed.
ref: http://redfish.dmtf.org/schemas/v1/FabricAdapter.v1_4_0.json
Tested: Validator passes #
```
curl -k https://$bmc/redfish/v1/Systems/system/FabricAdapters/disk_backplane0
{
"@odata.id": "/redfish/v1/Systems/system/FabricAdapters/disk_backplane0",
"@odata.type": "#FabricAdapter.v1_4_0.FabricAdapter",
"Id": "disk_backplane0",
"Location": {
"PartLocation": {
"ServiceLabel": "U78DA.ND0.WZS0042-P1"
}
},
"Model": "6B89",
"Name": "Fabric Adapter",
"PartNumber": "02WG682",
"SerialNumber": "YA31UF09P002",
"SparePartNumber": "02WG681",
"Status": {
"Health": "OK",
"State": "Enabled"
}
}
```
Change-Id: I1fc4549fbac37189e29ba5e49137634b14a08a36
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
diff --git a/redfish-core/lib/fabric_adapters.hpp b/redfish-core/lib/fabric_adapters.hpp
index ba52e67..768a2f7 100644
--- a/redfish-core/lib/fabric_adapters.hpp
+++ b/redfish-core/lib/fabric_adapters.hpp
@@ -144,6 +144,32 @@
});
}
+inline void
+ getFabricAdapterHealth(const std::shared_ptr<bmcweb::AsyncResp>& aResp,
+ const std::string& serviceName,
+ const std::string& fabricAdapterPath)
+{
+ sdbusplus::asio::getProperty<bool>(
+ *crow::connections::systemBus, serviceName, fabricAdapterPath,
+ "xyz.openbmc_project.State.Decorator.OperationalStatus", "Functional",
+ [aResp](const boost::system::error_code ec, const bool functional) {
+ if (ec)
+ {
+ if (ec.value() != EBADR)
+ {
+ BMCWEB_LOG_ERROR << "DBUS response error for Health";
+ messages::internalError(aResp->res);
+ }
+ return;
+ }
+
+ if (!functional)
+ {
+ aResp->res.jsonValue["Status"]["Health"] = "Critical";
+ }
+ });
+}
+
inline void doAdapterGet(const std::shared_ptr<bmcweb::AsyncResp>& aResp,
const std::string& systemName,
const std::string& adapterId,
@@ -160,10 +186,12 @@
"redfish", "v1", "Systems", systemName, "FabricAdapters", adapterId);
aResp->res.jsonValue["Status"]["State"] = "Enabled";
+ aResp->res.jsonValue["Status"]["Health"] = "OK";
getFabricAdapterLocation(aResp, serviceName, fabricAdapterPath);
getFabricAdapterAsset(aResp, serviceName, fabricAdapterPath);
getFabricAdapterState(aResp, serviceName, fabricAdapterPath);
+ getFabricAdapterHealth(aResp, serviceName, fabricAdapterPath);
}
inline bool checkFabricAdapterId(const std::string& adapterPath,