cppcheck: Fix Ineffective call of function 'substr'
This likely has no performance implications in practice, but getting a
clean cppcheck run is good. Suggestion was implemented per cppcheck.
Tested: This is in the deprecated rest API. Not sure how much testing
we need to do.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1658697730ac07c7cdefd2b73c80ee65fba4dedb
diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp
index 0e3e070..2cb2bc3 100644
--- a/include/openbmc_dbus_rest.hpp
+++ b/include/openbmc_dbus_rest.hpp
@@ -2040,7 +2040,7 @@
{
destProperty = objectPath.substr(attrPosition + strlen(attrSeperator),
objectPath.length());
- objectPath = objectPath.substr(0, attrPosition);
+ objectPath.resize(attrPosition);
}
if (req.method() == boost::beast::http::verb::post)
@@ -2052,7 +2052,7 @@
std::string postProperty =
objectPath.substr((actionPosition + strlen(actionSeperator)),
objectPath.length());
- objectPath = objectPath.substr(0, actionPosition);
+ objectPath.resize(actionPosition);
handleAction(req, asyncResp, objectPath, postProperty);
return;
}