tree a2cdd7a257753d87de520bb01d712a55dd11254a
parent e155ab54ec5ad4c31937f4d7de8b502e91468e43
author Ed Tanous <edtanous@google.com> 1644859925 -0800
committer Ed Tanous <ed@tanous.net> 1659413227 +0000

Simplify fillMessageArgs

The aforementioned function does a lot of reconstruction of strings as
args are filled in.  This results in the end of the string being copied
many times (N).  Replace the algorithm with one that builds a new
string, using reserve (which is good practice) and is also capable of
returning errors in the case of bad entries.  fillMessageArgs now
returns a string instead of trying to do things in place, which avoids
the initial std::string construction, so we should be net the same here.

Given this new algorithm can now detect failures in parsing (ie, trying
to parse %1 with no arguments) add unit tests for coverage of that, and
modify event manager slightly to handle errors.

Tested: Unit tests pass.  Pretty good coverage of this stuff.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I16f28a2ac78580fb35266561f5ae38078b471989