commit 81584abe2616373033281ab2ec75407fc50306d1
author Jiaqing Zhao <jiaqing.zhao@intel.com> Thu Jul 28 00:33:45 2022 +0800
committer Ed Tanous <ed@tanous.net> Thu Aug 04 17:22:15 2022 +0000
tree 33391dd09de4f371c9e916014c7e4aad77f1e339
parent 827c4902835d3175a36d90808a51304f744203ce

log_services: PostCode: Do not populate nextLink when reaches end

According to Redfish spec 9.6.12 Next link (Members@odata.nextLink)
property, it shall only be present if the number of members in the
resource collection is greater than the number of members returned,
and if the payload does not represent the end of the requested resource
collection. This patch fixes the issue that the nextLink property will
always be present even if the request reaches end in PostCode LogEntry
collection.

Tested:
Verified Members@odata.nextLink in PostCode LogEntry collection is only
populated when ($top + $skip < Members@odata.count).
Redfish Service Validator passed.

Change-Id: I24feca331b279f62f00259e9ec5ca9a8d4c19557
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

redfish-core/lib/log_services.hpp

diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index 6f46a7f..a04dfb5 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -3397,7 +3397,7 @@
             getPostCodeForBoot(aResp, static_cast<uint16_t>(bootIndex + 1),
                                bootCount, endCount, skip, top);
         }
-        else
+        else if (skip + top < endCount)
         {
             aResp->res.jsonValue["Members@odata.nextLink"] =
                 "/redfish/v1/Systems/system/LogServices/PostCodes/Entries?$skip=" +