commit 818db200c0e651896d5dddd081d56b180a4b9314
author Ed Tanous <edtanous@google.com> Mon Sep 11 09:58:39 2023 -0700
committer Ed Tanous <ed@tanous.net> Thu Sep 21 15:52:23 2023 +0000
tree 4b56d6213f39aafad33d77772c60ae1b47191c1f
parent 3e5faba56da7ac0cbb7eb2c51d521285775cda12

Fix unessesary URL read

This call was neccesary back when we were doing moves of a url_view, but
because this constructor doesn't use a url_view anymore, this isn't
neccesary.

Functionally, this clears up a strange unit test failure that occured in
some cases where this consturctor is used.  This constructor is not used
for anything but unit tests.

Tested: Unit tests pass.

Change-Id: I034a69d3a6b6aeada2460bb39f3518846b39f817
Signed-off-by: Ed Tanous <edtanous@google.com>

http/http_request.hpp

diff --git a/http/http_request.hpp b/http/http_request.hpp
index 5ce434b..cf0f417 100644
--- a/http/http_request.hpp
+++ b/http/http_request.hpp
@@ -43,13 +43,8 @@
         }
     }
 
-    Request(std::string_view bodyIn, std::error_code& ec) : req({}, bodyIn)
-    {
-        if (!setUrlInfo())
-        {
-            ec = std::make_error_code(std::errc::invalid_argument);
-        }
-    }
+    Request(std::string_view bodyIn, std::error_code& /*ec*/) : req({}, bodyIn)
+    {}
 
     Request() = default;