Fix .clang-tidy
camelLower is not a type, camelBack is.
Changes were made automatically with clang-tidy --fix-errors
To be able to apply changes automatically, the only way I've found that
works was to build the version of clang/clang-tidy that yocto has, and
run the fix script within bitbake -c devshell bmcweb. Unfortunately,
yocto has clang-tidy 11, which can apparently find a couple extra errors
in tests we already had enabled. As such, a couple of those are also
included.
Tested:
Ran clang-tidy-11 and got a clean result.
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I9d1080b67f0342229c2f267160849445c065ca51
diff --git a/http/http_connection.hpp b/http/http_connection.hpp
index 506f132..39ac39e 100644
--- a/http/http_connection.hpp
+++ b/http/http_connection.hpp
@@ -60,10 +60,10 @@
{
public:
Connection(Handler* handlerIn,
- std::function<std::string()>& get_cached_date_str_f,
+ std::function<std::string()>& getCachedDateStrF,
detail::TimerQueue& timerQueueIn, Adaptor adaptorIn) :
adaptor(std::move(adaptorIn)),
- handler(handlerIn), getCachedDateStr(get_cached_date_str_f),
+ handler(handlerIn), getCachedDateStr(getCachedDateStrF),
timerQueue(timerQueueIn)
{
parser.emplace(std::piecewise_construct, std::make_tuple());
@@ -498,9 +498,9 @@
adaptor, buffer, *parser,
[this,
self(shared_from_this())](const boost::system::error_code& ec,
- std::size_t bytes_transferred) {
+ std::size_t bytesTransferred) {
BMCWEB_LOG_ERROR << this << " async_read_header "
- << bytes_transferred << " Bytes";
+ << bytesTransferred << " Bytes";
bool errorWhileReading = false;
if (ec)
{
@@ -599,8 +599,8 @@
adaptor, buffer, *parser,
[this,
self(shared_from_this())](const boost::system::error_code& ec,
- std::size_t bytes_transferred) {
- BMCWEB_LOG_DEBUG << this << " async_read " << bytes_transferred
+ std::size_t bytesTransferred) {
+ BMCWEB_LOG_DEBUG << this << " async_read " << bytesTransferred
<< " Bytes";
bool errorWhileReading = false;
@@ -659,8 +659,8 @@
adaptor, *serializer,
[this,
self(shared_from_this())](const boost::system::error_code& ec,
- std::size_t bytes_transferred) {
- BMCWEB_LOG_DEBUG << this << " async_write " << bytes_transferred
+ std::size_t bytesTransferred) {
+ BMCWEB_LOG_DEBUG << this << " async_write " << bytesTransferred
<< " bytes";
cancelDeadlineTimer();