commit 82f80326afb1e1cfd6b682d4fa2f75319c83004f
author Konstantin Aladyshev <aladyshev22@gmail.com> Mon Jul 10 15:00:38 2023 +0300
committer Konstantin Aladyshev <aladyshev22@gmail.com> Tue Jul 11 15:17:55 2023 +0000
tree 99f7ef7e5d68205822abdc5bbfc1718062a46b45
parent 9bb0a7fe3c5dd3c3c9056dec7a37896af347912b

Omit Slot "Lanes" property if it is equal to 0

In the context of a PCIeSlot the 0 value for the 'Lanes' property
means undefined. According to the bmcweb guidelines, DBus properties
with "unknown"/"unspecified" values should be omitted from the Redfish
tree. Therefore don't populate 'Lanes' property if it is equal to 0.

Tested: validator passed

Change-Id: Ic3d142dd8b10da2367d73c370d5480208ba1510a
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

redfish-core/lib/pcie.hpp

diff --git a/redfish-core/lib/pcie.hpp b/redfish-core/lib/pcie.hpp
index 40fcd41..f5c5303 100644
--- a/redfish-core/lib/pcie.hpp
+++ b/redfish-core/lib/pcie.hpp
@@ -190,7 +190,10 @@
         res.jsonValue["Slot"]["PCIeType"] = *pcieType;
     }
 
-    res.jsonValue["Slot"]["Lanes"] = lanes;
+    if (lanes != 0)
+    {
+        res.jsonValue["Slot"]["Lanes"] = lanes;
+    }
 
     std::optional<pcie_slots::SlotTypes> redfishSlotType =
         pcie_util::dbusSlotTypeToRf(slotType);

redfish-core/lib/pcie_slots.hpp

diff --git a/redfish-core/lib/pcie_slots.hpp b/redfish-core/lib/pcie_slots.hpp
index 62fef3e..4412c41 100644
--- a/redfish-core/lib/pcie_slots.hpp
+++ b/redfish-core/lib/pcie_slots.hpp
@@ -83,7 +83,7 @@
         }
     }
 
-    if (lanes != nullptr)
+    if (lanes != nullptr && *lanes != 0)
     {
         slot["Lanes"] = *lanes;
     }