commit 82fd90f0550794f8f93877dfc7cfdb0aa3124ece
author Ratan Gupta <ratagupt@linux.vnet.ibm.com> Thu Mar 07 21:09:25 2019 +0530
committer Ed Tanous <ed.tanous@intel.com> Tue Mar 12 23:29:40 2019 +0000
tree 91bcf628ce24b888a9ae771545c09a0b3f5e91a5
parent f15aad376977bd1cef50854b5b1c39d27b026496

Redfish(Ethernet): Fix to not convert the json index into string

During Property Update for the Ipv4address, Index was getting
converted into string which was causing the bmcweb to crash.

This commit fixes this problem.

TestedBy:

Assumption: There is already three IP address and updating the
third one.
PATCH -D patch.txt -d '{"IPv4Addresses":
[{},{},{"Address": "x.x.x.x","AddressOrigin": "Static","SubnetMask": "255.255.0.0","Gateway":"x.x.x.x"}]}

Change-Id: Ic055649b75aaa36e16bda5d8dc4e4e9c87dcb315
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

redfish-core/lib/ethernet.hpp

diff --git a/redfish-core/lib/ethernet.hpp b/redfish-core/lib/ethernet.hpp
index 0bfe9db..8d7eddc 100644
--- a/redfish-core/lib/ethernet.hpp
+++ b/redfish-core/lib/ethernet.hpp
@@ -1019,9 +1019,9 @@
                                     messages::internalError(asyncResp->res);
                                     return;
                                 }
-                                asyncResp->res
-                                    .jsonValue["IPv4Addresses"][std::to_string(
-                                        entryIdx)]["Address"] = address;
+                                asyncResp->res.jsonValue["IPv4Addresses"]
+                                                        [entryIdx]["Address"] =
+                                    address;
                             };
 
                         crow::connections::systemBus->async_method_call(
@@ -1058,9 +1058,8 @@
                                     messages::internalError(asyncResp->res);
                                     return;
                                 }
-                                asyncResp->res
-                                    .jsonValue["IPv4Addresses"][std::to_string(
-                                        entryIdx)]["Gateway"] =
+                                asyncResp->res.jsonValue["IPv4Addresses"]
+                                                        [entryIdx]["Gateway"] =
                                     std::move(gateway);
                             };