log-services: fix clang-tidy warnings
A number of similar warnings about unsafe pointer arithmetic.
```
../redfish-core/lib/log_services.hpp:269:39: error: unsafe pointer arithmetic [-Werror,-Wunsafe-buffer-usage]
indexStr.data(), indexStr.data() + indexStr.size(), index);
```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icc4a0d2f418c76d6987ef2318b0098d30d116389
diff --git a/include/json_html_serializer.hpp b/include/json_html_serializer.hpp
index f23150e..8d5ed3c 100644
--- a/include/json_html_serializer.hpp
+++ b/include/json_html_serializer.hpp
@@ -233,8 +233,6 @@
// continue processing the string
state = utf8Accept;
break;
-
- break;
}
default: // decode found yet incomplete multi-byte code point
@@ -324,7 +322,7 @@
}
// use a pointer to fill the buffer
- auto bufferPtr = numberbuffer.begin();
+ auto* bufferPtr = numberbuffer.begin();
const bool isNegative = std::is_same<NumberType, int64_t>::value &&
!(number >= 0); // see issue #755
@@ -420,7 +418,7 @@
return;
}
- auto end = numberbuffer.begin();
+ auto* end = numberbuffer.begin();
std::advance(end, len);
end = std::remove(numberbuffer.begin(), end, ',');
std::fill(end, numberbuffer.end(), '\0');
@@ -434,7 +432,7 @@
out.append(numberbuffer.data(), static_cast<std::size_t>(len));
// determine if need to append ".0"
- auto newEnd = numberbuffer.begin();
+ auto* newEnd = numberbuffer.begin();
std::advance(newEnd, len + 1);
const bool valueIsIntLike =