commit 86a5ac983f9715f7b1a0f8dee355906ac648e1d3
author Ed Tanous <edtanous@google.com> Tue May 23 14:41:29 2023 -0700
committer Ed Tanous <ed@tanous.net> Tue May 30 17:45:55 2023 +0000
tree ab5140cf9dfacfdfa1a062c3d5e6d599b99924e4
parent dd1c4a9ca36e742fc4796a152cd72b850738a648

Break out methods

"Like we do other places.. blah"

Tested: Top commit was tested.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8a254067f97569a4d07817796b89a95cd768ff18

redfish-core/lib/metric_report_definition.hpp

diff --git a/redfish-core/lib/metric_report_definition.hpp b/redfish-core/lib/metric_report_definition.hpp
index fdd86d4..54607a8 100644
--- a/redfish-core/lib/metric_report_definition.hpp
+++ b/redfish-core/lib/metric_report_definition.hpp
@@ -743,6 +743,38 @@
 };
 } // namespace telemetry
 
+inline void
+    handleMetricReportGet(App& app, const crow::Request& req,
+                          const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
+                          const std::string& id)
+{
+    if (!redfish::setUpRedfishRoute(app, req, asyncResp))
+    {
+        return;
+    }
+
+    sdbusplus::asio::getAllProperties(
+        *crow::connections::systemBus, telemetry::service,
+        telemetry::getDbusReportPath(id), telemetry::reportInterface,
+        [asyncResp, id](const boost::system::error_code& ec,
+                        const dbus::utility::DBusPropertiesMap& properties) {
+        if (ec.value() == EBADR || ec == boost::system::errc::host_unreachable)
+        {
+            messages::resourceNotFound(asyncResp->res, "MetricReportDefinition",
+                                       id);
+            return;
+        }
+        if (ec)
+        {
+            BMCWEB_LOG_ERROR << "respHandler DBus error " << ec;
+            messages::internalError(asyncResp->res);
+            return;
+        }
+
+        telemetry::fillReportDefinition(asyncResp, id, properties);
+        });
+}
+
 inline void handleMetricReportDelete(
     App& app, const crow::Request& req,
     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp, const std::string& id)
@@ -861,37 +893,7 @@
                  "/redfish/v1/TelemetryService/MetricReportDefinitions/<str>/")
         .privileges(redfish::privileges::getMetricReportDefinition)
         .methods(boost::beast::http::verb::get)(
-            [&app](const crow::Request& req,
-                   const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
-                   const std::string& id) {
-        if (!redfish::setUpRedfishRoute(app, req, asyncResp))
-        {
-            return;
-        }
-
-        sdbusplus::asio::getAllProperties(
-            *crow::connections::systemBus, telemetry::service,
-            telemetry::getDbusReportPath(id), telemetry::reportInterface,
-            [asyncResp,
-             id](const boost::system::error_code& ec,
-                 const dbus::utility::DBusPropertiesMap& properties) {
-            if (ec.value() == EBADR ||
-                ec == boost::system::errc::host_unreachable)
-            {
-                messages::resourceNotFound(asyncResp->res,
-                                           "MetricReportDefinition", id);
-                return;
-            }
-            if (ec)
-            {
-                BMCWEB_LOG_ERROR << "respHandler DBus error " << ec;
-                messages::internalError(asyncResp->res);
-                return;
-            }
-
-            telemetry::fillReportDefinition(asyncResp, id, properties);
-            });
-        });
+            std::bind_front(handleMetricReportGet, std::ref(app)));
 
     BMCWEB_ROUTE(app,
                  "/redfish/v1/TelemetryService/MetricReportDefinitions/<str>/")