Change operationFailed to return 502
Redfish base registry for operation failed says:
"Indicates that one of the internal operations necessary to complete the
request failed. Examples of this are when an internal service provider
is unable to complete the request, such as in aggregation or RDE."
In terms of return codes, this translates to 502, Bad Gateway, given
that we're talking about proxy behavior here.
There is currently one usage of messages::operationFailed, which
arguably should've used internalErrror, and will be fixed in the next
patchset.
Tested: Code compiles. No (correct) users.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iff20e04d4f297b9f6595039f76321d0927f86c4d
diff --git a/redfish-core/src/error_messages.cpp b/redfish-core/src/error_messages.cpp
index 95bbea7..df62230 100644
--- a/redfish-core/src/error_messages.cpp
+++ b/redfish-core/src/error_messages.cpp
@@ -889,7 +889,7 @@
void operationFailed(crow::Response& res)
{
- res.result(boost::beast::http::status::internal_server_error);
+ res.result(boost::beast::http::status::bad_gateway);
addMessageToErrorJson(res.jsonValue, operationFailed());
}