Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / bmcweb / de629b6ea81bf5308bdcbe5610ec8ea27a4016be
commitde629b6ea81bf5308bdcbe5610ec8ea27a4016be[log] [tgz]
authorShawn McCarney <shawnmm@us.ibm.com>Fri Mar 08 10:42:51 2019 -0600
committerEd Tanous <ed.tanous@intel.com>Wed Mar 20 15:13:53 2019 +0000
treebf1783d07ef59d9cf0dc1ccac9ca55eec747099c
parent95897b20269638316c0f3262b8ea17a3e5329dd5 [diff]
Redfish: Enhance and fix power/thermal sensors

Made the following enhancements for Redfish power/thermal sensors:
* Now dynamically obtains the DBus object path to pass to
  GetManagedObjects() when getting sensor values.  Was previously
  hard-coded to "/" which didn't work on some systems.
* Added "fan_tach" to list of DBus sensor types returned when thermal
  sensors are requested.
* Added support for one-chassis systems.

Made the following fixes:
* Fixed @odata.id value when power sensors are requested.  Previously
  returned "/redfish/v1/Chassis/chassis/Thermal".
* Renamed "PowerSupply" to "PowerSupplies" to conform to schema.
* Removed 6 properties that were being returned for PowerSupplies that
  were not in the schema.
* Added check to make sure no sensors of the wrong type were being
  returned.  Previously if the same connection (service) provided both power
  and thermal sensors, both types of sensors were always returned.

Test Plan:
  https://gist.github.com/smccarney/79186e8510ba5479e846f2592d44d059

Tested: Verified the URLs /redfish/v1/Chassis/<chassis>/Power and
        /redfish/v1/Chassis/<chassis>/Thermal return the correct sensor
        names and values on a Witherspoon system.  Verified fixes listed
        above worked.  Ran Redfish Service Validator.

Change-Id: I4bae615cb61fc436b3c0a9a5c4d6b4566a3ddaa6
Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
3 files changed
tree: bf1783d07ef59d9cf0dc1ccac9ca55eec747099c
  1. cmake/
  2. crow/
  3. include/
  4. redfish-core/
  5. scripts/
  6. src/
  7. static/
  8. .clang-format
  9. .clang-tidy
  10. .gitignore
  11. aspeed_purley.cmake
  12. build_x86.sh
  13. cmake-format.json
  14. CMakeLists.txt
  15. CMakeLists.txt.in
  16. DEVELOPING.md
  17. JenkinsFile
  18. LICENCE
  19. MAINTAINERS
  20. pam-webserver
  21. README.md
README.md

OpenBMC webserver

This component attempts to be a "do everything" embedded webserver for openbmc.

Capabilities

At this time, the webserver implements a few interfaces:

  • Authentication middleware that supports cookie and token based authentication, as well as CSRF prevention backed by linux PAM authentication credentials.
  • An (incomplete) attempt at replicating phosphor-dbus-rest interfaces in C++. Right now, a few of the endpoint definitions work as expected, but there is still a lot of work to be done. The portions of the interface that are functional are designed to work correctly for phosphor-webui, but may not yet be complete.
  • Replication of the rest-dbus backend interfaces to allow bmc debug to logged in users.
  • An initial attempt at a read-only redfish interface. Currently the redfish interface targets ServiceRoot, SessionService, AccountService, Roles, and ManagersService. Some functionality here has been shimmed to make development possible. For example, there exists only a single user role.
  • SSL key generation at runtime. See the configuration section for details.
  • Static file hosting. Currently, static files are hosted from the fixed location at /usr/share/www. This is intended to allow loose coupling with yocto projects, and allow overriding static files at build time.
  • Dbus-monitor over websocket. A generic endpoint that allows UIs to open a websocket and register for notification of events to avoid polling in single page applications. (this interface may be modified in the future due to security concerns.

Configuration

BMCWeb is configured by setting -D flags that correspond to options in bmcweb/CMakeLists.txt and then compiling. For example, cmake -DBMCWEB_ENABLE_KVM=NO ... followed by make. The option names become C++ preprocessor symbols that control which code is compiled into the program.

When BMCWeb starts running, it reads persistent configuration data (such as UUID and session data) from a local file. If this is not usable, it generates a new configuration.

When BMCWeb SSL support is enabled and a usable certificate is not found, it will generate a self-sign a certificate before launching the server. The keys are generated by the prime256v1 algorithm. The certificate

  • is issued by C=US, O=Intel BMC, CN=testhost,
  • is valid for 10 years,
  • has a random serial number, and
  • is signed using the SHA-256 algorithm.

Crow patches

The crow project has had a number of additions to make it more useful for use in the OpenBmc Project. A non-exhaustive list is below. At the time of this writing, the crow project is not accepting patches, so for the time being crow will simply be checked in as is.

  • Applied clang-format to the whole crow tree. This was done without regard for arrays and fixed data structures, but was deemed to be overall better than the inconsistent formatting that existed in upstream previously.
  • Crow server now calls stop before destruction of the Crow app object.
  • Fixed a bug where timed out websockets would seg fault the system by accessing a destroyed socket object without null checks when in SSL mode.
  • Added a TestSocketAdapter class that could be used to unit test server behavior without utilizing a socket.
  • Added the "getRoutes" call to both the app and the routing Trie class that allows consumers to poll the server for all (or a subset of) registered web routes in the system.
  • Hardcoded the websocket implementation for binary mode, instead of leaving protocol unspecified.
  • Move most uses of std::unordered_map to boost::flat_map to lower memory consumption, and (in some cases) to improve memory locality.
  • Adjust the addHeaders mechanism to use a fixed string instead of a full map implementation to avoid unnecessary mallocs and reduce the number of scatter gather buffers on an http response.
  • Change server name header from Crow/0.1 to iBMC
  • Starts the http server io_context inside the main thread, instead of creating a new thread.
  • Removes all BMCWEB_MSVC_WORKAROUND flags.
  • Removes the behavior that causes a 301 redirect for paths that end in "/", and simply returns the endpoint requested. This was done for redfish compatibility.
  • Removes the built in crow/json.hpp package and adds nlohmann json package as the first class json package for crow.
  • Move uses of boost::array to std::array where possible.
  • Add the ability to get a reference to the crow::Request object on websocket connection to allow checking header values.
  • Patch http handler to call middlewares on websocket connections to allow authentication to be applied appropriately.
  • Adds an is_secure flag to provide information about whether or not the payload was delivered over ssl.