commit 8d1b46d7f8d39db2ba048f9e9007106ca3a28c9b
author zhanghch05 <zhanghch05@inspur.com> Thu Apr 01 11:18:24 2021 +0800
committer zhanghch05 <zhanghch05@inspur.com> Thu Apr 08 09:01:21 2021 +0800
tree 821fcb9b383fdf3db22db77e154cd7f57606d402
parent dab0604af234bdd5010407031a01343d6c242edf

Using AsyncResp everywhere

Get the core using AsyncResp everywhere, and not have each individual handler
creating its own object.We can call app.handle() without fear of the response
getting ended after the first tree is done populating.
Don't use res.end() anymore.

Tested:
1. Validator passed.

Signed-off-by: zhanghaicheng <zhanghch05@inspur.com>
Change-Id: I867367ce4a0caf8c4b3f4e07e06c11feed0782e8

redfish-core/include/utils/collection.hpp

diff --git a/redfish-core/include/utils/collection.hpp b/redfish-core/include/utils/collection.hpp
index f1b7f21..b6603b9 100644
--- a/redfish-core/include/utils/collection.hpp
+++ b/redfish-core/include/utils/collection.hpp
@@ -23,7 +23,7 @@
  * @return void
  */
 inline void
-    getCollectionMembers(std::shared_ptr<AsyncResp> aResp,
+    getCollectionMembers(std::shared_ptr<bmcweb::AsyncResp> aResp,
                          const std::string& collectionPath,
                          const std::vector<const char*>& interfaces,
                          const char* subtree = "/xyz/openbmc_project/inventory")

redfish-core/include/utils/fw_utils.hpp

diff --git a/redfish-core/include/utils/fw_utils.hpp b/redfish-core/include/utils/fw_utils.hpp
index 1e29139..c990023 100644
--- a/redfish-core/include/utils/fw_utils.hpp
+++ b/redfish-core/include/utils/fw_utils.hpp
@@ -32,7 +32,7 @@
  * @return void
  */
 inline void
-    populateFirmwareInformation(const std::shared_ptr<AsyncResp>& aResp,
+    populateFirmwareInformation(const std::shared_ptr<bmcweb::AsyncResp>& aResp,
                                 const std::string& fwVersionPurpose,
                                 const std::string& activeVersionPropName,
                                 const bool populateLinkToImages)
@@ -324,7 +324,7 @@
  *
  * @return void
  */
-inline void getFwStatus(const std::shared_ptr<AsyncResp>& asyncResp,
+inline void getFwStatus(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
                         const std::shared_ptr<std::string>& swId,
                         const std::string& dbusSvc)
 {
@@ -382,8 +382,9 @@
  * @param[i,o] asyncResp  Async response object
  * @param[i]   fwId       The firmware ID
  */
-inline void getFwUpdateableStatus(const std::shared_ptr<AsyncResp>& asyncResp,
-                                  const std::shared_ptr<std::string>& fwId)
+inline void
+    getFwUpdateableStatus(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
+                          const std::shared_ptr<std::string>& fwId)
 {
     crow::connections::systemBus->async_method_call(
         [asyncResp, fwId](const boost::system::error_code ec,

redfish-core/include/utils/telemetry_utils.hpp

diff --git a/redfish-core/include/utils/telemetry_utils.hpp b/redfish-core/include/utils/telemetry_utils.hpp
index 0a3af5f..5872350 100644
--- a/redfish-core/include/utils/telemetry_utils.hpp
+++ b/redfish-core/include/utils/telemetry_utils.hpp
@@ -15,8 +15,9 @@
 constexpr const char* metricReportUri =
     "/redfish/v1/TelemetryService/MetricReports/";
 
-inline void getReportCollection(const std::shared_ptr<AsyncResp>& asyncResp,
-                                const std::string& uri)
+inline void
+    getReportCollection(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
+                        const std::string& uri)
 {
     const std::array<const char*, 1> interfaces = {reportInterface};