commit 8d1b46d7f8d39db2ba048f9e9007106ca3a28c9b
author zhanghch05 <zhanghch05@inspur.com> Thu Apr 01 11:18:24 2021 +0800
committer zhanghch05 <zhanghch05@inspur.com> Thu Apr 08 09:01:21 2021 +0800
tree 821fcb9b383fdf3db22db77e154cd7f57606d402
parent dab0604af234bdd5010407031a01343d6c242edf

Using AsyncResp everywhere

Get the core using AsyncResp everywhere, and not have each individual handler
creating its own object.We can call app.handle() without fear of the response
getting ended after the first tree is done populating.
Don't use res.end() anymore.

Tested:
1. Validator passed.

Signed-off-by: zhanghaicheng <zhanghch05@inspur.com>
Change-Id: I867367ce4a0caf8c4b3f4e07e06c11feed0782e8

redfish-core/lib/roles.hpp

diff --git a/redfish-core/lib/roles.hpp b/redfish-core/lib/roles.hpp
index de2e1ff..8e00d43 100644
--- a/redfish-core/lib/roles.hpp
+++ b/redfish-core/lib/roles.hpp
@@ -86,25 +86,26 @@
     }
 
   private:
-    void doGet(crow::Response& res, const crow::Request&,
+    void doGet(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
+               const crow::Request&,
                const std::vector<std::string>& params) override
     {
         if (params.size() != 1)
         {
-            messages::internalError(res);
-            res.end();
+            messages::internalError(asyncResp->res);
+
             return;
         }
         const std::string& roleId = params[0];
         nlohmann::json privArray = nlohmann::json::array();
         if (false == getAssignedPrivFromRole(roleId, privArray))
         {
-            messages::resourceNotFound(res, "Role", roleId);
-            res.end();
+            messages::resourceNotFound(asyncResp->res, "Role", roleId);
+
             return;
         }
 
-        res.jsonValue = {
+        asyncResp->res.jsonValue = {
             {"@odata.type", "#Role.v1_2_2.Role"},
             {"Name", "User Role"},
             {"Description", roleId + " User Role"},
@@ -114,7 +115,6 @@
             {"RoleId", roleId},
             {"@odata.id", "/redfish/v1/AccountService/Roles/" + roleId},
             {"AssignedPrivileges", std::move(privArray)}};
-        res.end();
     }
 };
 
@@ -133,14 +133,15 @@
     }
 
   private:
-    void doGet(crow::Response& res, const crow::Request&,
-               const std::vector<std::string>&) override
+    void doGet(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
+               const crow::Request&, const std::vector<std::string>&) override
     {
-        auto asyncResp = std::make_shared<AsyncResp>(res);
-        res.jsonValue = {{"@odata.id", "/redfish/v1/AccountService/Roles"},
-                         {"@odata.type", "#RoleCollection.RoleCollection"},
-                         {"Name", "Roles Collection"},
-                         {"Description", "BMC User Roles"}};
+
+        asyncResp->res.jsonValue = {
+            {"@odata.id", "/redfish/v1/AccountService/Roles"},
+            {"@odata.type", "#RoleCollection.RoleCollection"},
+            {"Name", "Roles Collection"},
+            {"Description", "BMC User Roles"}};
 
         crow::connections::systemBus->async_method_call(
             [asyncResp](const boost::system::error_code ec,