commit 8e8245db1812bb0ec294a1c9a97c3a65558840ed
author Ed Tanous <ed@tanous.net> Thu Apr 11 22:21:38 2024 -0700
committer Ed Tanous <ed@tanous.net> Sat Apr 13 15:28:14 2024 +0000
tree 3c0d049cd5eddb5ff8e7364129dab0aac1278678
parent 6f056f246d9bcfd611102ee712d4a2935504b448

Fix nullptr failures for image upload

Several places that call *req.ioService were missing nullptr checks.
Add them, and fix the one case where it might not be filled in.

Tested:  With HTTP2 enabled, the following command succeeds.
```
curl -k https://192.168.7.2/redfish/v1/UpdateService/update -F 'UpdateParameters={"Targets":["/redfish/v1/Managers/bmc"]} ;type=application/json' --user "root:0penBmc" -F UpdateFile=@/home/ed/bmcweb/16mb.txt -v -H "Expect:"
```

Change-Id: I81e7944c22f5922d461bf5d231086c7468a16e62
Signed-off-by: Ed Tanous <ed@tanous.net>

http/http2_connection.hpp

diff --git a/http/http2_connection.hpp b/http/http2_connection.hpp
index d5f4481..3e0c394 100644
--- a/http/http2_connection.hpp
+++ b/http/http2_connection.hpp
@@ -246,6 +246,8 @@
             }
         }
         crow::Request& thisReq = it->second.req;
+        thisReq.ioService = static_cast<decltype(thisReq.ioService)>(
+            &adaptor.get_executor().context());
         BMCWEB_LOG_DEBUG("Handling {} \"{}\"", logPtr(&thisReq),
                          thisReq.url().encoded_path());
 

include/image_upload.hpp

diff --git a/include/image_upload.hpp b/include/image_upload.hpp
index ef615cb..8b3dc10 100644
--- a/include/image_upload.hpp
+++ b/include/image_upload.hpp
@@ -31,6 +31,12 @@
         asyncResp->res.result(boost::beast::http::status::service_unavailable);
         return;
     }
+    if (req.ioService == nullptr)
+    {
+        asyncResp->res.result(
+            boost::beast::http::status::internal_server_error);
+        return;
+    }
     // Make this const static so it survives outside this method
     static boost::asio::steady_timer timeout(*req.ioService,
                                              std::chrono::seconds(5));

redfish-core/lib/certificate_service.hpp

diff --git a/redfish-core/lib/certificate_service.hpp b/redfish-core/lib/certificate_service.hpp
index 5dc4413..6fba827 100644
--- a/redfish-core/lib/certificate_service.hpp
+++ b/redfish-core/lib/certificate_service.hpp
@@ -766,6 +766,12 @@
         return;
     }
 
+    if (req.ioService == nullptr)
+    {
+        messages::internalError(asyncResp->res);
+        return;
+    }
+
     // Make this static so it survives outside this method
     static boost::asio::steady_timer timeout(*req.ioService);
     timeout.expires_after(std::chrono::seconds(timeOut));

redfish-core/lib/update_service.hpp

diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index 9ef8311..8617071 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -405,6 +405,12 @@
         return;
     }
 
+    if (req.ioService == nullptr)
+    {
+        messages::internalError(asyncResp->res);
+        return;
+    }
+
     fwAvailableTimer =
         std::make_unique<boost::asio::steady_timer>(*req.ioService);