commit 9301e9113f98db6700bf1f87c9834d0cf8b844cd
author Ed Tanous <edtanous@google.com> Sun Aug 22 15:02:34 2021 -0700
committer Ed Tanous <ed@tanous.net> Tue Aug 24 17:14:51 2021 +0000
tree 0b1568f267d5c0d0d699281c81feea6caf40dca2
parent 4147b8ac88c79949f2f9f5c2738aca53641e22c8

Fix warning with clang

When this code is compiled with clang, it gives a warning about
condition that can never be true.  Truth be told, comparing a uint64_t
against < 0 will in fact, never be true.

Tested:
Compiled with clang.  Code compiles.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I89872664cc781497489a9af3e9218ed65dd5e648

include/event_service_store.hpp

diff --git a/include/event_service_store.hpp b/include/event_service_store.hpp
index b04fe0c..345b690 100644
--- a/include/event_service_store.hpp
+++ b/include/event_service_store.hpp
@@ -217,7 +217,6 @@
                 const uint64_t* value =
                     element.value().get_ptr<const uint64_t*>();
                 if ((value == nullptr) ||
-                    (*value < std::numeric_limits<uint32_t>::lowest()) ||
                     (*value > std::numeric_limits<uint32_t>::max()))
                 {
                     continue;
@@ -229,7 +228,6 @@
                 const uint64_t* value =
                     element.value().get_ptr<const uint64_t*>();
                 if ((value == nullptr) ||
-                    (*value < std::numeric_limits<uint32_t>::lowest()) ||
                     (*value > std::numeric_limits<uint32_t>::max()))
                 {
                     continue;