commit 93cf0ac2c7921d3344fa112f667c47a838e3b7d6
author Ed Tanous <ed@tanous.net> Thu Mar 28 00:35:13 2024 -0700
committer Ed Tanous <ed@tanous.net> Mon Apr 01 16:06:10 2024 +0000
tree baf607a094de6dd4dd165e29b50c81085f6d059d
parent 06fc9bebd8c9146636b53f2a04d340230bf21e29

Fix SSE sockets

Redfish protocol validatator has SSE tests that expose some bad coding
practies in SSE handlers, namely, that there are several cases where we
don't check for nullptr.

Fix them.

This appears to have been introduced in:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/41319

Tested: Redfish service validator passes more tests.

Change-Id: Id980725f007d044b7d120dbe0f4b625865cab6ba
Signed-off-by: Ed Tanous <ed@tanous.net>

test/http/server_sent_event_test.cpp

diff --git a/test/http/server_sent_event_test.cpp b/test/http/server_sent_event_test.cpp
index 3e740cb..7400779 100644
--- a/test/http/server_sent_event_test.cpp
+++ b/test/http/server_sent_event_test.cpp
@@ -34,7 +34,7 @@
 
     std::shared_ptr<ConnectionImpl<boost::beast::test::stream>> conn =
         std::make_shared<ConnectionImpl<boost::beast::test::stream>>(
-            io, std::move(stream), openHandler, closeHandler);
+            std::move(stream), openHandler, closeHandler);
     conn->start();
     // Connect
     {