commit 93f7a0d6a328037147d610a97a4dbeedc38414ef
author Ed Tanous <edtanous@google.com> Mon Dec 19 16:12:09 2022 -0800
committer Ed Tanous <ed@tanous.net> Wed Dec 21 21:29:17 2022 +0000
tree b3c1ee58ef584d47e00c78ab6440979937ce6d5c
parent afb9ee06281deea4944016396736a9bc35865094

Use owning strings for aggregator URI

Clang correctly notes that, because the segments() object is an rvalue,
and is destroyed after the std::string_view is used on the next line,
this is technically undefined behavior.  Make these use owning
std::strings instead of std::string_view to avoid the lifetime problem.

Tested:
Enabled aggregation without including a satellite config.  Sending a
GET request to /redfish/v1/Chassis/5B247A_Test returned a 404 due to
hitting one of the sections of changed code.  The other section is not
currently reachable, but uses the same type of change.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1b2b2ad444e2718c0cb167f4506ea1d0915b3a5b
Signed-off-by: Carson Labrado <clabrado@google.com>

redfish-core/include/redfish_aggregator.hpp

diff --git a/redfish-core/include/redfish_aggregator.hpp b/redfish-core/include/redfish_aggregator.hpp
index 8170b64..7778482 100644
--- a/redfish-core/include/redfish_aggregator.hpp
+++ b/redfish-core/include/redfish_aggregator.hpp
@@ -435,7 +435,7 @@
         }
 
         // We didn't recognize the prefix and need to return a 404
-        std::string_view nameStr = req.urlView.segments().back();
+        std::string nameStr = req.urlView.segments().back();
         messages::resourceNotFound(asyncResp->res, "", nameStr);
     }
 
@@ -460,7 +460,7 @@
             // don't need to write an error code
             if (isCollection == AggregationType::Resource)
             {
-                std::string_view nameStr = sharedReq->urlView.segments().back();
+                std::string nameStr = sharedReq->urlView.segments().back();
                 messages::resourceNotFound(asyncResp->res, "", nameStr);
             }
             return;