tree 909f2b3a05fbba3a1a508ede7f2d847c3573256a
parent 897967def41b35ec39069bee365eeee8a1111bd9
author Santosh Puranik <santosh.puranik@in.ibm.com> 1563961712 -0500
committer Ed Tanous <ed.tanous@intel.com> 1564768758 +0000

Fixed Accelerator State

This commit fixes a bug in getAcceleratorDataByService
when looking up the Present and Functional properties
on D-Bus.

The properties are booleans, but the code was trying
to read them as strings.

Tested:
-- Redfish validator comes out clean
-- Tested various combinations of present and functional
   properties on the GPU inventory objects:

xyz.openbmc_project.Inventory.Manager
/xyz/openbmc_project/inventory/system/chassis/motherboard/gv100card0
xyz.openbmc_project.State.Decorator.OperationalStatus Functional b "false"

/xyz/openbmc_project/inventory/system/chassis/motherboard/gv100card0
xyz.openbmc_project.Inventory.Item Present b "true"

$ curl -k -H "X-Auth-Token: $bmc_token" -X GET
https://${bmc}/redfish/v1/Systems/system/Processors/gv100card0
{
  "@odata.context": "/redfish/v1/$metadata#Processor.Processor",
  "@odata.id": "/redfish/v1/Systems/system/Processors/gv100card0",
  "@odata.type": "#Processor.v1_3_1.Processor",
  "Id": "gv100card0",
  "Name": "Processor",
  "ProcessorType": "Accelerator",
  "Status": {
    "Health": "OK",
    "State": "UnavailableOffline"
}

Set functional but not present:

$ curl -k -H "X-Auth-Token: $bmc_token" -X GET
https://${bmc}/redfish/v1/Systems/system/Processors/gv100card0
{
  "@odata.context": "/redfish/v1/$metadata#Processor.Processor",
  "@odata.id": "/redfish/v1/Systems/system/Processors/gv100card0",
  "@odata.type": "#Processor.v1_3_1.Processor",
  "Id": "gv100card0",
  "Name": "Processor",
  "ProcessorType": "Accelerator",
  "Status": {
    "Health": "OK",
    "State": "Absent"
}

Set functional and present:

$ curl -k -H "X-Auth-Token: $bmc_token" -X GET
https://${bmc}/redfish/v1/Systems/system/Processors/gv100card0
{
  "@odata.context": "/redfish/v1/$metadata#Processor.Processor",
  "@odata.id": "/redfish/v1/Systems/system/Processors/gv100card0",
  "@odata.type": "#Processor.v1_3_1.Processor",
  "Id": "gv100card0",
  "Name": "Processor",
  "ProcessorType": "Accelerator",
  "Status": {
    "Health": "OK",
    "State": "Enabled"
}

Set not functional and not present:

$ curl -k -H "X-Auth-Token: $bmc_token" -X GET
https://${bmc}/redfish/v1/Systems/system/Processors/gv100card0
{
  "@odata.context": "/redfish/v1/$metadata#Processor.Processor",
  "@odata.id": "/redfish/v1/Systems/system/Processors/gv100card0",
  "@odata.type": "#Processor.v1_3_1.Processor",
  "Id": "gv100card0",
  "Name": "Processor",
  "ProcessorType": "Accelerator",
  "Status": {
    "Health": "OK",
    "State": "Absent"
}

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Ic5ccc9bcd3b2b245ffdd714105d5b4fed3ca4ea4