Implement a new way of unpacking json to structs
The existing way of decoding json structures, while fast has some disadvantages.
1. it's very verbose to write.
2. It requires in depth knowlege of redfish error messages to get
correct.
3. It _can_ lead to undesired behavior, like half of a patch being
applied, if only some of the values have bad types.
This commit implements a new interface for decoding redfish json
named.... readJson. It is a templated function, that lets you decode
json values based on type easily, while still handling all the correct
error codes that were handled previously. Use is done similar to the
example below:
std::string required;
boost::optional<std::string> optional;
if (!json_util::readJson(req, res, "OptionalParam", optional,
"RequiredParam", required))
{
return;
}
if (optional){
// optional param was given, take action.
}
As part of this patchset, the systems schema is moved to the new
interface, which deletes some of the code involved and shows the
improvement in clarity.
Change-Id: I041a97c84d294df8cd4de4c2702e5ee22c0bc120
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
5 files changed
tree: 779224bc1c29105e0228626ea7335b610e266ddc
- cmake/
- crow/
- include/
- redfish-core/
- scripts/
- src/
- static/
- .clang-format
- .clang-tidy
- .gitignore
- aspeed_purley.cmake
- build_x86.sh
- cmake-format.json
- CMakeLists.txt
- CMakeLists.txt.in
- DEVELOPING.md
- JenkinsFile
- LICENCE
- MAINTAINERS
- pam-webserver
- README.md
- settings.hpp.in
README.md
OpenBMC webserver
This component attempts to be a "do everything" embedded webserver for openbmc.
Capabilities
At this time, the webserver implements a few interfaces:
- Authentication middleware that supports cookie and token based authentication, as well as CSRF prevention backed by linux PAM authentication credentials.
- An (incomplete) attempt at replicating phosphor-dbus-rest interfaces in C++. Right now, a few of the endpoint definitions work as expected, but there is still a lot of work to be done. The portions of the interface that are functional are designed to work correctly for phosphor-webui, but may not yet be complete.
- Replication of the rest-dbus backend interfaces to allow bmc debug to logged in users.
- An initial attempt at a read-only redfish interface. Currently the redfish interface targets ServiceRoot, SessionService, AccountService, Roles, and ManagersService. Some functionality here has been shimmed to make development possible. For example, there exists only a single user role.
- SSL key generation at runtime. If an RSA key and cert pair are not available to the server at runtime, keys are generated using the openssl routines, and written to disk.
- Static file hosting. Currently, static files are hosted from the fixed location at /usr/share/www. This is intended to allow loose coupling with yocto projects, and allow overriding static files at build time.
- Dbus-monitor over websocket. A generic endpoint that allows UIs to open a websocket and register for notification of events to avoid polling in single page applications. (this interface may be modified in the future due to security concerns.
Crow patches
The crow project has had a number of additions to make it more useful for use in the OpenBmc Project. A non-exhaustive list is below. At the time of this writing, the crow project is not accepting patches, so for the time being crow will simply be checked in as is.
- Applied clang-format to the whole crow tree. This was done without regard for arrays and fixed data structures, but was deemed to be overall better than the inconsistent formatting that existed in upstream previously.
- Crow server now calls stop before destruction of the Crow app object.
- Fixed a bug where timed out websockets would seg fault the system by accessing a destroyed socket object without null checks when in SSL mode.
- Added a TestSocketAdapter class that could be used to unit test server behavior without utilizing a socket.
- Added the "getRoutes" call to both the app and the routing Trie class that allows consumers to poll the server for all (or a subset of) registered web routes in the system.
- Hardcoded the websocket implementation for binary mode, instead of leaving protocol unspecified.
- Move most uses of std::unordered_map to boost::flat_map to lower memory consumption, and (in some cases) to improve memory locality.
- Adjust the addHeaders mechanism to use a fixed string instead of a full map implementation to avoid unnecessary mallocs and reduce the number of scatter gather buffers on an http response.
- Change server name header from Crow/0.1 to iBMC
- Starts the http server io_service inside the main thread, instead of creating a new thread.
- Removes all BMCWEB_MSVC_WORKAROUND flags.
- Removes the behavior that causes a 301 redirect for paths that end in "/", and simply returns the endpoint requested. This was done for redfish compatibility.
- Removes the built in crow/json.hpp package and adds nlohmann json package as the first class json package for crow.
- Move uses of boost::array to std::array where possible.
- Add the ability to get a reference to the crow::Request object on websocket connection to allow checking header values.
- Patch http handler to call middlewares on websocket connections to allow authentication to be applied appropriately.
- Adds an is_secure flag to provide information about whether or not the payload was delivered over ssl.