commit 97d2a47ddc8f11f796e4f4eba48423a8fba732c2
author Lei YU <mine260309@gmail.com> Tue Jun 11 17:44:27 2019 +0800
committer Ed Tanous <ed.tanous@intel.com> Fri Jun 14 15:59:53 2019 +0000
tree 8c68f077113de65a14a2d5fea2d4254ef1413e62
parent cee58b238fefd7ba49c55989cc5e0ece97c6509d

REST: PUT: return DBus error description

sdbusplus adds message::get_error() to provide the actual sd_bus_error
of a message.
With this, return the error's name and message in REST API so that the
correct error is returned to end user.

Tested: Verify the REST API output when trying to set host time while
        the settings does not allow that:

        $ curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" -X PUT -d '{"data": 1436655598435272}' https://$bmc/xyz/openbmc_project/time/bmc/attr/Elapsed
        {
          "data": {
            "description": "xyz.openbmc_project.Time.Error.NotAllowed"
          },
          "message": "The operation is not allowed",
          "status": "error"
        }

Resolves openbmc/bmcweb#83

Change-Id: I0bd5405c6748d124f9dd8a341e29f3918445158e
Signed-off-by: Lei YU <mine260309@gmail.com>

CMakeLists.txt.in

diff --git a/CMakeLists.txt.in b/CMakeLists.txt.in
index 02a1104..06b9cfb 100644
--- a/CMakeLists.txt.in
+++ b/CMakeLists.txt.in
@@ -9,7 +9,7 @@
 externalproject_add (
     sdbusplus-project PREFIX ${CMAKE_BINARY_DIR}/sdbusplus-project
     GIT_REPOSITORY https://github.com/openbmc/sdbusplus.git GIT_TAG
-    8cd7a4a10c02a450bc21580a4bde34328a841d13 SOURCE_DIR
+    c08cf5283b80a071d19506d9a462f6c69e1797f1 SOURCE_DIR
     ${CMAKE_BINARY_DIR}/sdbusplus-src BINARY_DIR
     ${CMAKE_BINARY_DIR}/sdbusplus-build CONFIGURE_COMMAND "" BUILD_COMMAND cd
     ${CMAKE_BINARY_DIR}/sdbusplus-src && ./bootstrap.sh && ./configure

include/openbmc_dbus_rest.hpp

diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp
index af6451d..398612f 100644
--- a/include/openbmc_dbus_rest.hpp
+++ b/include/openbmc_dbus_rest.hpp
@@ -1866,14 +1866,15 @@
                                                     BMCWEB_LOG_DEBUG << "sent";
                                                     if (ec)
                                                     {
+                                                        const sd_bus_error *e =
+                                                            m.get_error();
                                                         setErrorResponse(
                                                             transaction->res,
                                                             boost::beast::http::
                                                                 status::
                                                                     forbidden,
-                                                            ec.category()
-                                                                .name(),
-                                                            ec.message());
+                                                            e->name,
+                                                            e->message);
                                                     }
                                                     else
                                                     {