Correct comment to reflect PrivilegeRegistry
Looking at
https://redfish.dmtf.org/registries/Redfish_1.5.0_PrivilegeRegistry.json
a "Entity": "LogService", is
"POST": [
{
"Privilege": [
"ConfigureManager"
below it is a SubordinateOverrides for
"Targets": [
"ComputerSystem",
with
"POST": [
{
"Privilege": [
"ConfigureComponents"
which is what this LogService is. Update the comment to reflect the
ConfigureComponents is correct.
Found in review on https://gerrit.openbmc.org/c/openbmc/bmcweb/+/74272/
Tested: Inspection only. Comment change only.
Change-Id: I4ffc7d973bb7146c78a8762dde1a42f4c4203a3c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/redfish-core/lib/systems_logservices_postcodes.hpp b/redfish-core/lib/systems_logservices_postcodes.hpp
index b5f0175..90782bd 100644
--- a/redfish-core/lib/systems_logservices_postcodes.hpp
+++ b/redfish-core/lib/systems_logservices_postcodes.hpp
@@ -586,8 +586,8 @@
BMCWEB_ROUTE(
app,
"/redfish/v1/Systems/<str>/LogServices/PostCodes/Actions/LogService.ClearLog/")
- // The following privilege is incorrect; It should be ConfigureManager
- //.privileges(redfish::privileges::postLogService)
+ // The following privilege is correct; we need "SubordinateOverrides"
+ // before we can automate it.
.privileges({{"ConfigureComponents"}})
.methods(boost::beast::http::verb::post)(std::bind_front(
handleSystemsLogServicesPostCodesPost, std::ref(app)));