tree 8468b1f65609852551437bf76247517c1a990d4a
parent 877044644f53d4dd93499d3a99d8c227694fd3a5
author Ali Ahmed <ama213000@gmail.com> 1630439998 -0500
committer Ali Ahmed <ama213000@gmail.com> 1630655191 -0500

Have ProcessorSummary correctly set Status

Remove unnecessary condition, and correctly get Status
from Present and Functional properties.

Removal of if, else code:
1. If condition never evaluates to false ('else' branch is never taken)
   Properties size will always be 7 as that's how it's defined here [1]

Context:
The 'if' code branch was originally there for a company that was NOT
following the d-bus interfaces. See commit 57e8c9b [2] & gerrit [3].
Later, properties were added to the Inventory.Item.Cpu interface,
so now everyone is hitting this 'if' branch. See commit 259f49e [4].

The code in the 'else' condition uses Inventory.Item Present and
State.Decorator.OperationalStatus Function to determine Redfish "Count",
"Status""State", "Status""Health", since this is the correct way to
determine Redfish Status.

Summary:
1) Removes the if/else condition, and
2) Retains the code that was in the else condition

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master
/yaml/xyz/openbmc_project/Inventory/Item/Cpu.interface.yaml

[2] https://github.com/openbmc/bmcweb/commit/57e8c9b

[3] https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/20572/4

[4] https://github.com/openbmc/phosphor-dbus-interfaces/commit/259f49e

Tested:

curl -k -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system
Before:
...
  "ProcessorSummary": {
    "Count": 0,
    "Status": {
      "Health": "OK",
      "HealthRollup": "OK",
      "State": "Disabled"
    }
  },
...

After:
...
  "ProcessorSummary": {
    "Count": 2,
    "Status": {
      "Health": "OK",
      "HealthRollup": "OK",
      "State": "Enabled"
    }
  },
...

Signed-off-by: Ali Ahmed <ama213000@gmail.com>
Change-Id: I1a38086b87f4f1e2ebbfa3b5058d95158d29002a