openbmc_message_registry: update failure reason in FirmwareUpdateFailed
Update the failure reason in FirmwareUpdateFailed redfish message entry.
Tested:
1. Update the corrupted image so that fw update fails.
POST: https://<BMC_IP>/redfish/v1/UpdateService/
with <Corrupted_Update_Capsule> binary file
Check event logs in redfish.
Command: GET: https://<BMC_IP>/redfish/v1/Systems/system/LogServices/
EventLog/Entries
Response:
{
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/
Entries/1591111739",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2020-06-02T15:28:59+00:00",
"EntryType": "Event",
"Id": "1591111739",
"Message": "BMC firmware update to version 00.59 started.",
"MessageArgs": [
"BMC",
"00.59",
""
],
"MessageId": "OpenBMC.0.1.FirmwareUpdateStarted",
"Name": "System Event Log Entry",
"Severity": "OK"
},
{
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/
Entries/1591111742",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2020-06-02T15:29:02+00:00",
"EntryType": "Event",
"Id": "1591111742",
"Message": "BMC firmware update to version 00.59 failed: due to
image verification error.",
"MessageArgs": [
"BMC",
"00.59",
"due to image verification error"
],
"MessageId": "OpenBMC.0.1.FirmwareUpdateFailed",
"Name": "System Event Log Entry",
"Severity": "Warning"
},
Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: I79e9509f129a3b87fb21e961e7b7bd78809ca1e2
diff --git a/redfish-core/include/registries/openbmc_message_registry.hpp b/redfish-core/include/registries/openbmc_message_registry.hpp
index 17b2070..ec0f068 100644
--- a/redfish-core/include/registries/openbmc_message_registry.hpp
+++ b/redfish-core/include/registries/openbmc_message_registry.hpp
@@ -418,10 +418,10 @@
MessageEntry{"FirmwareUpdateFailed",
{
"Indicates a firmware update has failed.",
- "%1 firmware update to version %2 failed.",
+ "%1 firmware update to version %2 failed: %3.",
"Warning",
- 2,
- {"string", "string"},
+ 3,
+ {"string", "string", "string"},
"None.",
}},
MessageEntry{"FirmwareUpdateStarted",